Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbdLUKZm (ORCPT ); Thu, 21 Dec 2017 05:25:42 -0500 Received: from merlin.infradead.org ([205.233.59.134]:56016 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbdLUKZj (ORCPT ); Thu, 21 Dec 2017 05:25:39 -0500 Date: Thu, 21 Dec 2017 11:25:30 +0100 From: Peter Zijlstra To: Viresh Kumar Cc: Patrick Bellasi , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Ingo Molnar , "Rafael J . Wysocki" , Vincent Guittot , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Todd Kjos , Joel Fernandes Subject: Re: [PATCH v3 0/6] cpufreq: schedutil: fixes for flags updates Message-ID: <20171221102530.all2hqoyh77mffmf@hirez.programming.kicks-ass.net> References: <20171130114723.29210-1-patrick.bellasi@arm.com> <20171220153029.dqrtjbyowhqdl56r@hirez.programming.kicks-ass.net> <20171220154358.663yoodeoxkqghx7@hirez.programming.kicks-ass.net> <20171221091502.GE19815@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171221091502.GE19815@vireshk-i7> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 597 Lines: 20 On Thu, Dec 21, 2017 at 02:45:02PM +0530, Viresh Kumar wrote: > On 20-12-17, 16:43, Peter Zijlstra wrote: > > The below makes more sense to me too; hmm? > > > > @@ -335,12 +335,11 @@ static unsigned int sugov_next_freq_shar > > > > j_max = j_sg_cpu->max; > > j_util = sugov_aggregate_util(j_sg_cpu); > > + sugov_iowait_boost(j_sg_cpu, &util, &max); This should 'obviously' have been: sugov_iowait_boost(j_sg_cpu, &j_util, *j_max); > > if (j_util * max > j_max * util) { > > util = j_util; > > max = j_max; > > } > > - > > - sugov_iowait_boost(j_sg_cpu, &util, &max);