Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753310AbdLUKx4 (ORCPT ); Thu, 21 Dec 2017 05:53:56 -0500 Received: from ozlabs.org ([103.22.144.67]:37901 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753264AbdLUKxx (ORCPT ); Thu, 21 Dec 2017 05:53:53 -0500 From: Michael Ellerman To: Vincent Legoll , mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Vincent Legoll Subject: Re: [PATCH] virtio: make VIRTIO a menuconfig to ease disabling it all In-Reply-To: <20171209152657.4762-1-vincent.legoll@gmail.com> References: <20171209152657.4762-1-vincent.legoll@gmail.com> Date: Thu, 21 Dec 2017 21:53:44 +1100 Message-ID: <87tvwkfj2f.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1394 Lines: 52 Vincent Legoll writes: > No need to get into the submenu to disable all VIRTIO-related > config entries. > > This makes it easier to disable all VIRTIO config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the outside menu. > > This is only intended to change menuconfig UI, not change > the config dependencies. > > Signed-off-by: Vincent Legoll > --- > drivers/virtio/Kconfig | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > index cff773f15b7e..d485a63a8233 100644 > --- a/drivers/virtio/Kconfig > +++ b/drivers/virtio/Kconfig > @@ -5,7 +5,10 @@ config VIRTIO > bus, such as CONFIG_VIRTIO_PCI, CONFIG_VIRTIO_MMIO, CONFIG_RPMSG > or CONFIG_S390_GUEST. > > -menu "Virtio drivers" > +menuconfig VIRTIO_MENU > + bool "Virtio drivers" > + > +if VIRTIO_MENU This breaks all existing .configs *and* defconfigs that use VIRTIO. Please don't do that. If you make it default y then everything will continue to work. cheers diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index d485a63a8233..35897649c24f 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig @@ -7,6 +7,7 @@ config VIRTIO menuconfig VIRTIO_MENU bool "Virtio drivers" + default y if VIRTIO_MENU