Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751907AbdLUNkU (ORCPT ); Thu, 21 Dec 2017 08:40:20 -0500 Received: from mga06.intel.com ([134.134.136.31]:28227 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbdLUNkS (ORCPT ); Thu, 21 Dec 2017 08:40:18 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,435,1508828400"; d="scan'208";a="4668656" Message-ID: <1513863613.2785.6.camel@intel.com> Subject: Re: [PATCH 1/2] thermal: mtk: Cleanup unused defines From: Zhang Rui To: Matthias Brugger , edubezval@gmail.com Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Matthias Brugger Date: Thu, 21 Dec 2017 21:40:13 +0800 In-Reply-To: References: <20171201104321.8410-1-matthias.bgg@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1843 Lines: 66 On Thu, 2017-12-21 at 11:01 +0100, Matthias Brugger wrote: > > On 12/01/2017 11:43 AM, Matthias Brugger wrote: > > > > The mtk_thermal has some defiens which are never used within the > > driver. > > This patch delets them. > > > > Signed-off-by: Matthias Brugger > > --- > Rui, Eduardo, do you have any comments on this patch? > No, I don't have any. I suppose Eduardo will review them soon as I need the thermal soc material for next merge window. thanks, rui > Regards, > Matthias > > > > >  drivers/thermal/mtk_thermal.c | 9 +-------- > >  1 file changed, 1 insertion(+), 8 deletions(-) > > > > diff --git a/drivers/thermal/mtk_thermal.c > > b/drivers/thermal/mtk_thermal.c > > index 1e61c09153c9..c75661a3801a 100644 > > --- a/drivers/thermal/mtk_thermal.c > > +++ b/drivers/thermal/mtk_thermal.c > > @@ -32,15 +32,10 @@ > >  #include > >   > >  /* AUXADC Registers */ > > -#define AUXADC_CON0_V 0x000 > > -#define AUXADC_CON1_V 0x004 > >  #define AUXADC_CON1_SET_V 0x008 > >  #define AUXADC_CON1_CLR_V 0x00c > >  #define AUXADC_CON2_V 0x010 > >  #define AUXADC_DATA(channel) (0x14 + (channel) * 4) > > -#define AUXADC_MISC_V 0x094 > > - > > -#define AUXADC_CON1_CHANNEL(x) BIT(x) > >   > >  #define APMIXED_SYS_TS_CON1 0x604 > >   > > @@ -158,8 +153,6 @@ > >  /* The number of sensing points per bank */ > >  #define MT2712_NUM_SENSORS_PER_ZONE 4 > >   > > -#define THERMAL_NAME    "mtk-thermal" > > - > >  struct mtk_thermal; > >   > >  struct thermal_bank_cfg { > > @@ -765,7 +758,7 @@ static struct platform_driver > > mtk_thermal_driver = { > >   .probe = mtk_thermal_probe, > >   .remove = mtk_thermal_remove, > >   .driver = { > > - .name = THERMAL_NAME, > > + .name = "mtk-thermal", > >   .of_match_table = mtk_thermal_of_match, > >   }, > >  }; > >