Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752101AbdLUOMG (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Dec 2017 09:12:06 -0500
Received: from mail-qt0-f178.google.com ([209.85.216.178]:45107 "EHLO
        mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751381AbdLUOMB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Dec 2017 09:12:01 -0500
X-Google-Smtp-Source: ACJfBourjc9CILZLnVlbPGsj09JlwyshaKT40nq/Vgg12NhTONqAqRjflfsbhyhom30vobpvGdCncCRBoqJe5rZri7I=
MIME-Version: 1.0
In-Reply-To: <20171221134842.31287-5-brgl@bgdev.pl>
References: <20171221134842.31287-1-brgl@bgdev.pl> <20171221134842.31287-5-brgl@bgdev.pl>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 21 Dec 2017 16:12:00 +0200
Message-ID: <CAHp75Vfv6=HNz0Lyg3qdzXGzym6OTMRJTUphxuGMHRaWyLxxEQ@mail.gmail.com>
Subject: Re: [PATCH v2 4/5] dt-bindings: at24: extend the list of supported chips
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Javier Martinez Canillas <javier@dowhile0.org>,
        David Lechner <david@lechnology.com>,
        Divagar Mohandass <divagar.mohandass@intel.com>,
        linux-i2c <linux-i2c@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 879
Lines: 35

On Thu, Dec 21, 2017 at 3:48 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> Add other variants of at24 EEPROMs we support in the driver to the
> list of allowed compatible strings.

>          "atmel,24c00",
>          "atmel,24c01",
> +        "atmel,24cs01",
>          "atmel,24c02",
> +        "atmel,24cs02",
> +        "atmel,24mac402",
> +        "atmel,24mac602",
>          "atmel,spd",
>          "atmel,24c04",
> +        "atmel,24cs04",
>          "atmel,24c08",
> +        "atmel,24cs08",
>          "atmel,24c16",
> +        "atmel,24cs16",
>          "atmel,24c32",

Same comments as per spd case.

For me more naturally to have them grouped by letters inside, i.e.
          "atmel,24c00",
          "atmel,24c01",
...
        "atmel,24cs01",
        "atmel,24cs02",
...
       "atmel,24mac402",
       "atmel,24mac602",

-- 
With Best Regards,
Andy Shevchenko