MIME-Version: 1.0
In-Reply-To: <20171221090736.3ac9d5db@karo-electronics.de>
References: <1512575989-15627-1-git-send-email-marcofrk@gmail.com> <20171221090736.3ac9d5db@karo-electronics.de>
From: Marco Franchi <marcofrk@gmail.com>
Date: Thu, 21 Dec 2017 12:26:38 -0200
Message-ID: <CAM4PwSVzVn3=wWpFohw2q23Oiwp1FimCkdHPq=BfG-QzuuPtfQ@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: imx: Add memory node unit name
To: =?UTF-8?Q?Lothar_Wa=C3=9Fmann?= <LW@karo-electronics.de>
Cc: Shawn Guo <shawnguo@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org,
        Fabio Estevam <festevam@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1015
Lines: 32

Hi Lothar,

2017-12-21 6:07 GMT-02:00 Lothar Waßmann <LW@karo-electronics.de>:
> Hi,
>
> On Wed,  6 Dec 2017 13:59:49 -0200 Marco Franchi wrote:
>> Fix the following warnings from dtc by adding the unit name to memory
>> nodes:
>>
>> Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
>>
>> Converted using the following command:
>>
>> perl -p0777i -e 's/memory \{\n\t\treg = \<0x+([0-9a-f])/memory\@$1$\0000000 \{\n\t\treg = <0x$1/m' `find ./arch/arm/boot/dts -name "imx*"`
>>
>> The files below were manually fixed:
>> -imx1-ads.dts
>> -imx1-apf9328.dts
>>
> The imx*.dtsi files all have this:
> |       memory { device_type = "memory"; reg = <0 0>; };
> Thus you will end up with a 'memory' node with a reg = <0 0> entry and
> an additional 'memory@...' node with the correct 'reg' values.

You are right. The .dtb files were composed by two different memory nodes.
Do you have some recommendation to take off this specific warning?

>
>
> Lothar Waßmann

Marco Franchi