Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751294AbdLUOz1 (ORCPT ); Thu, 21 Dec 2017 09:55:27 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:54437 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbdLUOzX (ORCPT ); Thu, 21 Dec 2017 09:55:23 -0500 Date: Thu, 21 Dec 2017 15:55:12 +0100 From: Maxime Ripard To: kevans91@ksu.edu Cc: Srinivas Kandagatla , Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t Message-ID: <20171221145512.llxvzkcrjpquhczi@flea.lan> References: <20171219210523.10428-1-kevans91@ksu.edu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="45rdbikbqoxtunmt" Content-Disposition: inline In-Reply-To: <20171219210523.10428-1-kevans91@ksu.edu> User-Agent: NeoMutt/20171208 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1750 Lines: 49 --45rdbikbqoxtunmt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Kyle, On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > Allwinner a83t has a 1 KB sid block with efuse for security rootkey and > thermal calibration data, add node to describe it. >=20 > a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > supported in an external driver for FreeBSD. >=20 > Signed-off-by: Kyle Evans The patch looks fine in itself, but we've had a number of issues with the register layout (and access patterns) in the past, so I'd rather have something that works in Linux too if possible. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --45rdbikbqoxtunmt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlo7y08ACgkQ0rTAlCFN r3Sdtw//RjUAn+nlailzQ/dY7RubBYMwb0uvUBqTgIkGy4IM4PezPsYyWiy+fY9R xxyi+sFLpV4iF7NjAwekJpqmrHdEvP2dYmbrcoM7TYF6A89Li8qiQI25V4YCL6Jf IbqceaF8n9wMV2mFhoLkvJwsfnh5ESCbh+VnPaEvKK42hKQ+06MI4OoP4JguwYJb rM58xdvegiGf02lE3Xymv9t9+wg5JNMWGEtGB4B//kaTGrPqdrjrny1bbrGHPliR cn+PqI1ArYZhVlDwJHy9ROWzrYHl82N+5utJ9sqR82rUGZYvjN6hfycBTd3vPGQi oOijzNc2rk3fB0eaDjEuJTv5mJe52E8EFZZllOd1WQhV6xxU5iAr0fgZr8p1K47k Hku1jc38ebwMJI3mvovDpRCUcDf5tNeVGyDznIy0QNOsiRwa5WM+MSJ2MUrBmefF ytsJfl0kk2Kq8f62t6EFwf979HIGs/treY41pjvW0UzGKYA2t6oHumKvOHZ4DZqP Qv+KCUboKNSMSxK3I3C+P5n8C7N6JsfezG18DPbRSzP+WKLkn1DWbHqd7HA0vHy7 m6fM5PJ0zMr9CCL2aC9pnLJBt1+/CGnGbC0oOkVbk/QTrZ8qrMAZF2tSzJF1fcPR XWdIlzT7rswjjCg9SqKXfFG0wuWpVtVNI41nuiR1fiaB003WVoU= =+ESd -----END PGP SIGNATURE----- --45rdbikbqoxtunmt--