Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbdLUO7M (ORCPT ); Thu, 21 Dec 2017 09:59:12 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:58543 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752328AbdLUO7J (ORCPT ); Thu, 21 Dec 2017 09:59:09 -0500 Date: Thu, 21 Dec 2017 15:59:07 +0100 From: Pavel Machek To: Michael Ellerman , vojtech@suse.cz, jikos@suse.cz Cc: Kees Cook , "Michael Kerrisk (man-pages)" , Andrew Morton , Cyril Hrubis , Michal Hocko , Linux API , Khalid Aziz , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Matthew Wilcox , Jann Horn , Mike Rapoport Subject: known bad patch in -mm tree was Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation Message-ID: <20171221145907.GA7604@amd> References: <20171213125540.GA18897@amd> <20171213130458.GI25185@dhcp22.suse.cz> <20171213130900.GA19932@amd> <20171213131640.GJ25185@dhcp22.suse.cz> <20171213132105.GA20517@amd> <20171213144050.GG11493@rei> <87po78fe7m.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="pf9I7BMVVzbSWLtt" Content-Disposition: inline In-Reply-To: <87po78fe7m.fsf@concordia.ellerman.id.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1663 Lines: 52 --pf9I7BMVVzbSWLtt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>> And if Michal doesn't want to touch this patch any more, I'm happy to > >>> do the search/replace/resend. :P > >> > >> Something with the prefix MAP_FIXED_ seems to me obviously desirable, > >> both to suggest that the function is similar, and also for easy > >> grepping of the source code to look for instances of both. > >> MAP_FIXED_SAFE didn't really bother me as a name, but > >> MAP_FIXED_NOREPLACE (or MAP_FIXED_NOCLOBBER) seem slightly more > >> descriptive of what the flag actually does, so a little better. > > > > Great, thanks! > > > > Andrew, can you s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g in the series? >=20 > This seems to have not happened. Presumably Andrew just missed the mail > in the flood. And will probably miss this one too ... :) Nice way to mess up kernel development, Michal. Thank you! :-(. Andrew, everyone and their dog agrees MAP_FIXED_SAFE is stupid name, but Michal decided to just go ahead, ignoring feedback... Can you either s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g or drop the patches? Thanks, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --pf9I7BMVVzbSWLtt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlo7zDsACgkQMOfwapXb+vJPWgCbBfYtq66FI5JTa2xsFDGf0za9 djIAoJx/7xt2XwUfdzK545naG/32MRDV =vmt7 -----END PGP SIGNATURE----- --pf9I7BMVVzbSWLtt--