Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753275AbdLUPIx (ORCPT ); Thu, 21 Dec 2017 10:08:53 -0500 Received: from mx2.suse.de ([195.135.220.15]:60661 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190AbdLUPIp (ORCPT ); Thu, 21 Dec 2017 10:08:45 -0500 Date: Thu, 21 Dec 2017 16:08:40 +0100 From: Michal Hocko To: Pavel Machek Cc: Michael Ellerman , vojtech@suse.cz, jikos@suse.cz, Kees Cook , "Michael Kerrisk (man-pages)" , Andrew Morton , Cyril Hrubis , Linux API , Khalid Aziz , Russell King - ARM Linux , Andrea Arcangeli , Linux-MM , LKML , linux-arch , Florian Weimer , John Hubbard , Matthew Wilcox , Jann Horn , Mike Rapoport Subject: Re: known bad patch in -mm tree was Re: [PATCH 2/2] mmap.2: MAP_FIXED updated documentation Message-ID: <20171221150840.GF4831@dhcp22.suse.cz> References: <20171213130458.GI25185@dhcp22.suse.cz> <20171213130900.GA19932@amd> <20171213131640.GJ25185@dhcp22.suse.cz> <20171213132105.GA20517@amd> <20171213144050.GG11493@rei> <87po78fe7m.fsf@concordia.ellerman.id.au> <20171221145907.GA7604@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171221145907.GA7604@amd> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 40 On Thu 21-12-17 15:59:07, Pavel Machek wrote: > Hi! > > > >>> And if Michal doesn't want to touch this patch any more, I'm happy to > > >>> do the search/replace/resend. :P > > >> > > >> Something with the prefix MAP_FIXED_ seems to me obviously desirable, > > >> both to suggest that the function is similar, and also for easy > > >> grepping of the source code to look for instances of both. > > >> MAP_FIXED_SAFE didn't really bother me as a name, but > > >> MAP_FIXED_NOREPLACE (or MAP_FIXED_NOCLOBBER) seem slightly more > > >> descriptive of what the flag actually does, so a little better. > > > > > > Great, thanks! > > > > > > Andrew, can you s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g in the series? > > > > This seems to have not happened. Presumably Andrew just missed the mail > > in the flood. And will probably miss this one too ... :) > > Nice way to mess up kernel development, Michal. Thank you! :-(. Thank you for your valuable feedback! Maybe you have noticed that I haven't enforced the patch and led others to decide the final name (either by resubmitting patches or a simple replace in mmotm tree). Or maybe you haven't because you are so busy bikesheding that you can hardly see anything else. > Andrew, everyone and their dog agrees MAP_FIXED_SAFE is stupid name, > but Michal decided to just go ahead, ignoring feedback... > > Can you either s/MAP_FIXED_SAFE/MAP_FIXED_NOREPLACE/g or drop the patches? You have surely saved the world today and I hardly find words to thank you (and your dog of course). Thanks! -- Michal Hocko SUSE Labs