Date: Thu, 21 Dec 2017 16:26:30 +0100
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Kyle Evans <kevans91@ksu.edu>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Chen-Yu Tsai <wens@csie.org>, Russell King <linux@armlinux.org.uk>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t
Message-ID: <20171221152630.2vf57x5o2yi5sv3n@flea.lan>
References: <20171219210523.10428-1-kevans91@ksu.edu>
 <20171221145512.llxvzkcrjpquhczi@flea.lan>
 <CACNAnaE9GiVTXD-TV1xXyBJKtTGKpdA6n0REk6a=qm218EgHbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="5fxvazjmbj5axlhg"
Content-Disposition: inline
In-Reply-To: <CACNAnaE9GiVTXD-TV1xXyBJKtTGKpdA6n0REk6a=qm218EgHbg@mail.gmail.com>
User-Agent: NeoMutt/20171208
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2693
Lines: 72


--5fxvazjmbj5axlhg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote:
> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > Hi Kyle,
> >
> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote:
> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and
> >> thermal calibration data, add node to describe it.
> >>
> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is
> >> supported in an external driver for FreeBSD.
> >>
> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu>
> >
> > The patch looks fine in itself, but we've had a number of issues with
> > the register layout (and access patterns) in the past, so I'd rather
> > have something that works in Linux too if possible.
>=20
> I have a patch that I think should make it work fine on Linux [1], but
> I'm afraid I have little to no capability to test it myself and so I
> did not add it as well.
>=20
> I do know that the rootkey is offset 0x200 into the given space [2],
> as is the case with the H3, and that the readout quirk is not needed.
> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the
> H3, but I do know that thermal data can be found at 0x34 and 0x38 in
> this space.

Then maybe we should leave it aside until someone takes some time on
the A83t. The good news is that the binding itself looks fine, so as
far as FreeBSD goes, there shouldn't be anything preventing you from
using it I guess.

Chen-Yu, what do you think?

Thanks!
Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--5fxvazjmbj5axlhg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlo70qUACgkQ0rTAlCFN
r3TP3g/9H8znZxWVIVwz8TfVY/k4kDzBBj2YXt6QKr0S8HRoEtRuAO8Dlm8rmifp
k+d9I9wB8YK5sQSlqIhGcpnemCZVnPBEjERswT8nlq57PyQzTENZgfl3ilG+nPuU
hOjSQ6Nn6j0aVRBoQYqGrH6vACiVuAJVB6ZIp/wbPk2jiBRm0TToEd8450SggWEE
XwhFAWxwYFiFSBtyoThB80CkU8/ng+qL5c4lIn3bJO0XhUstoehv3dFBzf09qQF2
xXYlZA2qu1wbjH8inHVov/xYLe7wzszpCJJ3ZvVrZTs+aUAGrvmiqI1R9im2AcHI
TC0NB6yKM0MScqdGbKVG33Y96Tua6qni6qNIlWTre8rohwzxQIpCAzF5pUkfv4ar
QJCoekBhlPLvKkPABgGjKq3//EbFyRMdBMW4abTsGcJoMrH785AgXlB9XXZImIfT
/0vrsieqLKUU8RsAPeP1O83RtRsFlLu42Ljhx6hsoa0akuOK0jfnhGtIciT/3Blp
lAjAZH0qdX3qxYaQjaww3XSC2G7hcDonKcga1DMH4/O2pKfliTPH52nTMaFDdzlL
r+K+r5eihtKAOXOBiSrys0+ts2cY3/Sw0ZFz/hbP5EASr2RCf1Qzsvt/d3jsZ0N7
VfRuXK0VqELTsOBezwIGSbwjDNlaknPk95RaE2BVmBlQqs88bFE=
=SNsa
-----END PGP SIGNATURE-----

--5fxvazjmbj5axlhg--