MIME-Version: 1.0
In-Reply-To: <20171221152630.2vf57x5o2yi5sv3n@flea.lan>
References: <20171219210523.10428-1-kevans91@ksu.edu> <20171221145512.llxvzkcrjpquhczi@flea.lan>
 <CACNAnaE9GiVTXD-TV1xXyBJKtTGKpdA6n0REk6a=qm218EgHbg@mail.gmail.com> <20171221152630.2vf57x5o2yi5sv3n@flea.lan>
From: Kyle Evans <kevans91@ksu.edu>
Date: Thu, 21 Dec 2017 09:30:56 -0600
Message-ID: <CACNAnaF23H-S7-d3F1_GQeJFJh6RwA0=dX1nfM4SM3ikB2TE+A@mail.gmail.com>
Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t
To: Maxime Ripard <maxime.ripard@free-electrons.com>
CC: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Chen-Yu Tsai <wens@csie.org>, Russell King <linux@armlinux.org.uk>,
        <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-sunxi@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2017 15:31:20.9498
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 8137017c-97aa-4850-98a6-08d54887e39d
X-MS-Exchange-CrossTenant-Id: d9a2fa71-d67d-4cb6-b541-06ccaa8013fb
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d9a2fa71-d67d-4cb6-b541-06ccaa8013fb;Ip=[129.130.18.151];Helo=[ome-vm-smtp1.campus.ksu.edu]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR05MB2988
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1992
Lines: 51

On Thu, Dec 21, 2017 at 9:26 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi,
>
> On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote:
>> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > Hi Kyle,
>> >
>> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote:
>> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and
>> >> thermal calibration data, add node to describe it.
>> >>
>> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is
>> >> supported in an external driver for FreeBSD.
>> >>
>> >> Signed-off-by: Kyle Evans <kevans91@ksu.edu>
>> >
>> > The patch looks fine in itself, but we've had a number of issues with
>> > the register layout (and access patterns) in the past, so I'd rather
>> > have something that works in Linux too if possible.
>>
>> I have a patch that I think should make it work fine on Linux [1], but
>> I'm afraid I have little to no capability to test it myself and so I
>> did not add it as well.
>>
>> I do know that the rootkey is offset 0x200 into the given space [2],
>> as is the case with the H3, and that the readout quirk is not needed.
>> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the
>> H3, but I do know that thermal data can be found at 0x34 and 0x38 in
>> this space.
>
> Then maybe we should leave it aside until someone takes some time on
> the A83t. The good news is that the binding itself looks fine, so as
> far as FreeBSD goes, there shouldn't be anything preventing you from
> using it I guess.

Yeah, we've had this exact binding in our own copy of DTS up until a
recent point when we flipped the switch to pulling DT from Mainline
Linux and trying to upstream changes instead of having a bunch of
local modifications in our tree.

> Chen-Yu, what do you think?
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com