Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbdLUPkM (ORCPT ); Thu, 21 Dec 2017 10:40:12 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:56128 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753095AbdLUPju (ORCPT ); Thu, 21 Dec 2017 10:39:50 -0500 X-Google-Smtp-Source: ACJfBovm6+XOsxx0fh5dQhlmaI5zNeerxV+oA3T5FZ4kOefbMJXtTTJr9MyAfZ5h9XRHyoQ10Fjh9/zmDcsuCGKaowk= MIME-Version: 1.0 In-Reply-To: <20171221152630.2vf57x5o2yi5sv3n@flea.lan> References: <20171219210523.10428-1-kevans91@ksu.edu> <20171221145512.llxvzkcrjpquhczi@flea.lan> <20171221152630.2vf57x5o2yi5sv3n@flea.lan> From: Chen-Yu Tsai Date: Thu, 21 Dec 2017 23:39:21 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t To: Maxime Ripard Cc: Kyle Evans , Srinivas Kandagatla , Rob Herring , Mark Rutland , Chen-Yu Tsai , Russell King , devicetree , linux-arm-kernel , linux-kernel , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 42 On Thu, Dec 21, 2017 at 11:26 PM, Maxime Ripard wrote: > Hi, > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: >> On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard >> wrote: >> > Hi Kyle, >> > >> > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: >> >> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and >> >> thermal calibration data, add node to describe it. >> >> >> >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is >> >> supported in an external driver for FreeBSD. >> >> >> >> Signed-off-by: Kyle Evans >> > >> > The patch looks fine in itself, but we've had a number of issues with >> > the register layout (and access patterns) in the past, so I'd rather >> > have something that works in Linux too if possible. >> >> I have a patch that I think should make it work fine on Linux [1], but >> I'm afraid I have little to no capability to test it myself and so I >> did not add it as well. >> >> I do know that the rootkey is offset 0x200 into the given space [2], >> as is the case with the H3, and that the readout quirk is not needed. >> I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the >> H3, but I do know that thermal data can be found at 0x34 and 0x38 in >> this space. > > Then maybe we should leave it aside until someone takes some time on > the A83t. The good news is that the binding itself looks fine, so as > far as FreeBSD goes, there shouldn't be anything preventing you from > using it I guess. > > Chen-Yu, what do you think? Looks good to me. ChenYu