Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbdLUP4G (ORCPT ); Thu, 21 Dec 2017 10:56:06 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:46357 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbdLUP4F (ORCPT ); Thu, 21 Dec 2017 10:56:05 -0500 X-Google-Smtp-Source: ACJfBotSueD/OBxWCFDsWStWLua7IZoaQ0mrci/Y+iyf5h2XU4S2lYhknx21T758tfSoEA5WwNTYhw== From: Vasyl Gomonovych To: zohar@linux.vnet.ibm.com, dmitry.kasatkin@gmail.com, james.l.morris@oracle.com, serge@hallyn.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, gomonovych@gmail.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] ima: Fix warn potential negative subtraction from max Date: Thu, 21 Dec 2017 16:55:53 +0100 Message-Id: <1513871754-13943-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 24 Found by smatch: security/integrity/ima/ima_queue.c:122 ima_add_digest_entry() warn: potential negative subtraction from max '(~0)- size' Signed-off-by: Vasyl Gomonovych --- security/integrity/ima/ima_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/integrity/ima/ima_queue.c b/security/integrity/ima/ima_queue.c index a02a86d51102..446018478b81 100644 --- a/security/integrity/ima/ima_queue.c +++ b/security/integrity/ima/ima_queue.c @@ -116,7 +116,7 @@ static int ima_add_digest_entry(struct ima_template_entry *entry, } if (binary_runtime_size != ULONG_MAX) { - int size; + unsigned int size; size = get_binary_runtime_size(entry); binary_runtime_size = (binary_runtime_size < ULONG_MAX - size) ? -- 1.9.1