Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753104AbdLUP6H (ORCPT ); Thu, 21 Dec 2017 10:58:07 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:44278 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752509AbdLUP6D (ORCPT ); Thu, 21 Dec 2017 10:58:03 -0500 X-Google-Smtp-Source: ACJfBouaMXXq1Fhgf/lTE474W1IOIaA4DwxZIElQTNgV+sXsux/8DIuoqGEP3OgMP0ApPUTI4V7w0A== From: Vasyl Gomonovych To: casey@schaufler-ca.com, james.l.morris@oracle.com, serge@hallyn.com, linux-security-module@vger.kernel.org, gomonovych@gmail.com Cc: linux-kernel@vger.kernel.org Subject: [PATCH] Smack: fix dereferenced before check Date: Thu, 21 Dec 2017 16:57:52 +0100 Message-Id: <1513871872-18759-1-git-send-email-gomonovych@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 975 Lines: 33 This patch fixes the warning reported by smatch: security/smack/smack_lsm.c:2872 smack_socket_connect() warn: variable dereferenced before check 'sock->sk' (see line 2869) Signed-off-by: Vasyl Gomonovych --- security/smack/smack_lsm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 14cc7940b36d..30f2c3d1c11c 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -2866,12 +2866,16 @@ static int smack_socket_connect(struct socket *sock, struct sockaddr *sap, #endif #ifdef SMACK_IPV6_SECMARK_LABELING struct smack_known *rsp; - struct socket_smack *ssp = sock->sk->sk_security; + struct socket_smack *ssp; #endif if (sock->sk == NULL) return 0; +#ifdef SMACK_IPV6_SECMARK_LABELING + ssp = sock->sk->sk_security; +#endif + switch (sock->sk->sk_family) { case PF_INET: if (addrlen < sizeof(struct sockaddr_in)) -- 1.9.1