Date: Thu, 21 Dec 2017 18:13:05 +0100
From: Borislav Petkov <bp@alien8.de>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: x86@kernel.org, Brijesh Singh <brijesh.singh@amd.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1 3/3] x86/mm: Encrypt the initrd earlier for BSP
 microcode update
Message-ID: <20171221171305.ti2teebm5n5zazse@pd.tnic>
References: <20171207233342.29646.12858.stgit@tlendack-t1.amdoffice.net>
 <20171207233410.29646.27816.stgit@tlendack-t1.amdoffice.net>
 <20171221144925.76ge77xraapgzm36@pd.tnic>
 <cf742b88-49ac-7420-ebee-3523c267bde4@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cf742b88-49ac-7420-ebee-3523c267bde4@amd.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 754
Lines: 17

On Thu, Dec 21, 2017 at 10:48:29AM -0600, Tom Lendacky wrote:
> This is very early in the boot and the boot parameters have not been
> copied to boot_params yet, so I need the pointer.  And since the routines
> in arch/x86/kernel/setup.c also use boot_params, those would have to be
> modified to accept a pointer rather than automatically using boot_params.
> I'm not sure it's worth all that.

I fear that this computation of the ramdisk address and size keeps
duplicating around the tree. And you could pass in struct boot_params *
to those functions but ok, it is simple enough, so whatever. We can
always clean it up later if it grows unwieldy...

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.