Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753535AbdLURYU (ORCPT ); Thu, 21 Dec 2017 12:24:20 -0500 Received: from vern.gendns.com ([206.190.152.46]:35493 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752156AbdLURYR (ORCPT ); Thu, 21 Dec 2017 12:24:17 -0500 Subject: Re: [PATCH v2 1/5] dt-bindings: at24: consistently document the compatible property To: Bartosz Golaszewski Cc: Peter Rosin , Andy Shevchenko , Rob Herring , Mark Rutland , Javier Martinez Canillas , Divagar Mohandass , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171221134842.31287-1-brgl@bgdev.pl> <20171221134842.31287-2-brgl@bgdev.pl> <0c2455ae-2f68-5342-14c6-14706d6f0e66@axentia.se> From: David Lechner Message-ID: Date: Thu, 21 Dec 2017 11:24:22 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <0c2455ae-2f68-5342-14c6-14706d6f0e66@axentia.se> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 29 On 12/21/2017 10:20 AM, Peter Rosin wrote: > On 2017-12-21 14:48, Bartosz Golaszewski wrote: >> Current description of the compatible property for at24 is quite vague. >> >> Specify an exact list of accepted compatibles and document the - now >> deprecated - strings which were previously used in device tree files. > > Why is it suddenly deprecated to correctly specify what hardware you > have, e.g. "nxp,24c32". In this case the manufacturer is nxp, damnit. > Sure, it happens to be compatible with "atmel,24c32", but that is > supposed to be written with a fallback as > > "nxp,24c32", "atmel,24c32" > > if I understand correctly. So, why is that deprecated in this case? > > What if (a few years down the line) it is discovered that some weird > quirk is needed that is only appropriate for nxp chips? > > nxp is of course just an example, pick any manufacturer of eeproms > (supposedly) compatible with the atmel interface. > So now I am supposed to change my device tree from "microchip,24c128" to "atmel,24c128"? Also, at,24c08 is listed in Documentation/devicetree/bindings/trivial-devices.txt. It should probably be removed.