From: "Ghorai, Sukumar" <sukumar.ghorai@intel.com>
To: Guenter Roeck <linux@roeck-us.net>,
        Brian Norris <briannorris@chromium.org>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "Bag, Amit K" <amit.k.bag@intel.com>, Oliver Neukum <oneukum@suse.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        Matthias Kaehlcke <mka@chromium.org>, Todd Broch <tbroch@chromium.org>,
        Rajat Jain <rajatja@chromium.org>, Miao Chou <mcchou@chromium.org>,
        "Rao Pv, Sadashiva" <sadashiva.rao.pv@intel.com>
Subject: RE: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the
 usb-wakeup feature
Thread-Topic: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the
 usb-wakeup feature
Thread-Index: AQHTeBiC8oVj3QTsi0Oqz0MyEHEZXaNNLbWAgADUPACAAJQTgIAAEmKA//9/TxA=
Date: Thu, 21 Dec 2017 18:52:31 +0000
Message-ID: <D73ECEF0C711E34A8F972E4B87F5400579901388@ORSMSX114.amr.corp.intel.com>
References: <20171218152852.624624481@linuxfoundation.org>
 <20171220195112.GA1287@google.com> <20171221083052.GA19501@kroah.com>
 <CA+ASDXNABgtZCj7SF=-LvBZGwWB0uo4BiWGTzpmhEZcQUkZPRA@mail.gmail.com>
 <20171221182639.GA30333@roeck-us.net>
In-Reply-To: <20171221182639.GA30333@roeck-us.net>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.0.116
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2151
Lines: 45

>> Linus' tree is broken in 2 ways:
>>
>> 1. It includes this patch:
>> "Bluetooth: btusb: fix QCA Rome suspend/resume"
>> which is wrong, and we're on our way to reverting it upstream and
>> backporting that to -stable.
>>
>> 2. It includes $subject patch. I'm not quite so sure, but I believe
>> it's not 100% "wrong"; it's just tougher for user space to deal with,
>> since now by default, all sorts of BT devices are set to be wakeup
>> sources. We can account for that in user space by being more careful
>> with initiating BT activity before suspend, but we don't currently do
>> that (at least not with the BlueZ in ChromeOS).
>> A related portion of this problem is that we briefly thought that this
>> patch resolved regressions with 1. In the end, it might mask some, but
>> it does not actually fix the problem. But then, you only included this
>> patch because somebody suggested it could resolve 1...
>>
>> In the end, I'd say that #2 never belonged in -stable at all, and #1
>> was just "buggy" (so we're reverting it and letting the revert trickle
>> into -stable). I'm not sure I have a strong reason to revert #2
>> upstream, but I think I have an argument for not including it in
>> -stable.
>>
>> I'm not sure what you mean by "bug-compatible"; if I wanted to use a
>> buggy kernel, I'd use Linus' tree :)
>>
>> Or as I think I understand your point: the key point is that #2 might
>> not be actually a "bug", but a feature that user space has to be more
>> careful with. That may be a candidate for mainline, but not for
>> -stable, as I understand the current rules.
>>
>
>I absolutely agree with Brian here. #2, or commit a0085f2510e8 ("Bluetooth:
>btusb: driver to enable the usb-wakeup feature") does not fix a bug, was not
>tagged for stable, and should not have been applied to stable releases in the first
>place. That it has a potential to cause trouble is not even relevant here.

Bug: platform can't wake using LE mouse/ keyboatd or any other LE I/O device
connected. 
I feel we need to fix the other issue like S3 test fail, if any.  And one of the other day
we need all of them - wakeup using LE mouse, ..

>
..snip...