Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755539AbdLUTZ1 (ORCPT ); Thu, 21 Dec 2017 14:25:27 -0500 Received: from mail.parknet.co.jp ([210.171.160.6]:34164 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752732AbdLUTZY (ORCPT ); Thu, 21 Dec 2017 14:25:24 -0500 From: OGAWA Hirofumi To: Chen Guanqiao Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] fs: fat: add ioctl to modify fat filesystem partion volume label References: Date: Fri, 22 Dec 2017 04:25:20 +0900 In-Reply-To: (Chen Guanqiao's message of "Thu, 21 Dec 2017 20:56:39 +0800") Message-ID: <87fu83lw7z.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 797 Lines: 28 Chen Guanqiao writes: > The FAT filesystem partition volume label can be read with > FAT_IOCTL_GET_VOLUME_LABEL and written with FAT_IOCTL_SET_VOLUME_LABEL. > > v2: > 1. add filesystem version check. > 2. add diretory permissions check. > 3. add volume label string check. > 4. fixed part of return value. > 5. fixed some indent issue. > 6. remove sync_dirty_buffer(). As I said in previous email, those vol_label should be matching with volume label in root directory, right? So I think handling only boot sector's vol_label would not work as expected. Does this really works as expected? E.g. suspected test case is, 1) write label on windows 2) modify label on linux 3) read modified label on windows Thanks. -- OGAWA Hirofumi