Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755423AbdLUTgQ (ORCPT ); Thu, 21 Dec 2017 14:36:16 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42630 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbdLUTgL (ORCPT ); Thu, 21 Dec 2017 14:36:11 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4501760328 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Subject: Re: [PATCH 1/6] dt-bindings: soc: qcom: Add label for GLINK bindings To: Bjorn Andersson , Rob Herring Cc: Chris Lew , andy.gross@linaro.org, david.brown@linaro.org, aneela@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1513634534-22861-1-git-send-email-clew@codeaurora.org> <1513634534-22861-2-git-send-email-clew@codeaurora.org> <20171220183000.rhxgyikfqzxmqkjo@rob-hp-laptop> <20171221013557.GE12655@minitux> From: Stephen Boyd Message-ID: Date: Thu, 21 Dec 2017 11:36:09 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171221013557.GE12655@minitux> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 26 On 12/20/2017 05:35 PM, Bjorn Andersson wrote: > On Wed 20 Dec 10:30 PST 2017, Rob Herring wrote: > >> On Mon, Dec 18, 2017 at 02:02:09PM -0800, Chris Lew wrote: >>> Add a label property to identify the edge this node represents. >> Why does a user need to know this? >> > We have multiple remoteproc instances, each one having one or more > associated SMD or GLINK links (this node), exposing logical > communication channels. Some of these logical channels are exposed to > user space and we need a way to distinguish them there. > > In the current implementation of SMD this value goes straight into an > sysfs attribute that we can use when writing udev rules and for the DIAG > implementation to pair up channels related to the same remoteproc. This > adds the equivalent information for glink-backed channels. > > > I'm therefor in favor of picking this patch. Please add these details to the commit log. Just writing what the patch is doing isn't very helpful. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project