Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbdLUUKx (ORCPT ); Thu, 21 Dec 2017 15:10:53 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:32900 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbdLUUKs (ORCPT ); Thu, 21 Dec 2017 15:10:48 -0500 X-Google-Smtp-Source: ACJfBoshZJjT2i8vC+QN81kPAKXvyxqsNlpCLCEHomxwui/ntsqp5+4y5VuG2CvGNsoin9xm7zy0WQ== Date: Thu, 21 Dec 2017 12:10:46 -0800 From: Guenter Roeck To: "Ghorai, Sukumar" Cc: Brian Norris , "linux-kernel@vger.kernel.org" , "gregkh@linuxfoundation.org" , Marcel Holtmann , Oliver Neukum , "stable@vger.kernel.org" , "Bag, Amit K" , Matthias Kaehlcke , Todd Broch , Rajat Jain , Miao Chou , "Rao Pv, Sadashiva" Subject: Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the usb-wakeup feature Message-ID: <20171221201046.GC24020@roeck-us.net> References: <20171218152852.624624481@linuxfoundation.org> <20171220195112.GA1287@google.com> <20171221083052.GA19501@kroah.com> <20171221182639.GA30333@roeck-us.net> <20171221185830.GA219523@google.com> <20171221191057.GA222103@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 30 On Thu, Dec 21, 2017 at 07:23:27PM +0000, Ghorai, Sukumar wrote: > >> >Could you ever? If not, that looks like a feature request to me... > >> Agree, feature request... however we need this feature for rapid use of > >Bluetooth LE devices. > > > >Is that what -stable is for now? For getting your pet feature enabled more > >quickly? I thought that's what Linaro was for, or something like that. > > > >Besides the poor reasoning of the above (IMO): isn't that something you can also > >configure in user space? So, upgrade user space (e.g., BlueZ) to resolve the > >regressions that have been reported, then write the appropriate udev rules to > >turn this on? Or is that too "slow" for you? > Free to take decision.. > > I understand this feature is creating instability in other area. However - > 1. the problem will remain same when enable the usb-wakeup feature form > kernel or user-space or udev rule, and as long LE device is connected. There is a slight difference of leaving the decision to the user (or to userspace) or forcing it down the throat of everyone by adding it to the kernel. Your statement "I understand this feature is creating instability in other area" should really be a wakeup call. It almost sounds like you are aware that it is causing problems, but you don't care because it fits _your_ needs. I hope that is not the case, but if it is, please keep in mind that you are not the only user of the Linux kernel. Thanks, Guenter