Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755496AbdLUUkV (ORCPT ); Thu, 21 Dec 2017 15:40:21 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:58230 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752601AbdLUUkR (ORCPT ); Thu, 21 Dec 2017 15:40:17 -0500 Date: Thu, 21 Dec 2017 15:40:13 -0500 (EST) Message-Id: <20171221.154013.465159930243668403.davem@davemloft.net> To: sven.eckelmann@openmesh.com Cc: b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com, tom@herbertland.com, jiri@mellanox.com, linux-kernel@vger.kernel.org, edumazet@google.com Subject: Re: [PATCH v4 0/5] flow_dissector: Provide basic batman-adv unicast handling From: David Miller In-Reply-To: <20171221091742.8020-1-sven.eckelmann@openmesh.com> References: <20171221091742.8020-1-sven.eckelmann@openmesh.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 21 Dec 2017 12:40:17 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1534 Lines: 38 From: Sven Eckelmann Date: Thu, 21 Dec 2017 10:17:37 +0100 > we are currently starting to use batman-adv as mesh protocol on multicore > embedded devices. These usually don't have a lot of CPU power per core but > are reasonable fast when using multiple cores. > > It was noticed that sending was working very well but receiving was > basically only using on CPU core per neighbor. The reason for that is > format of the (normal) incoming packet: > > +--------------------+ > | ip(v6)hdr | > +--------------------+ > | inner ethhdr | > +--------------------+ > | batadv unicast hdr | > +--------------------+ > | outer ethhdr | > +--------------------+ > > The flow dissector will therefore stop after parsing the outer ethernet > header and will not parse the actual ipv(4|6)/... header of the packet. Our > assumption was now that it would help us to add minimal support to the flow > dissector to jump over the batman-adv unicast and inner ethernet header > (like in gre ETH_P_TEB). The patch was implemented in a slightly hacky > way [1] and the results looked quite promising. > > I didn't get any feedback how the files should actually be named. So I am > now just using the names from RFC v3 > > The discussion of the RFC v3 can be found in the related patches of > https://patchwork.ozlabs.org/cover/849345/ > > The discussion of the RFC v2 can be found in the related patches of > https://patchwork.ozlabs.org/cover/844783/ Series applied, thanks!