DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6B84B60710
Subject: Re: [PATCH 0/2] Make capsules in a contiguous virtual space
To: Ge Song <ge.song@hxt-semitech.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1513680554-5682-1-git-send-email-ge.song@hxt-semitech.com>
From: Richard Ruigrok <rruigrok@codeaurora.org>
Message-ID: <5851a90c-b334-9b28-d3b3-8eba7c933222@codeaurora.org>
Date: Thu, 21 Dec 2017 14:47:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <1513680554-5682-1-git-send-email-ge.song@hxt-semitech.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1099
Lines: 27

Please tested-by
Tested on Centiq, applied on v4.15-rc4.
This fixes the regression introduced in 4.13 where the capsule is no longer passed in contiguous virtual memory.

On 12/19/2017 3:49 AM, Ge Song wrote:
> Recently we found it failed to update firmware through capsule update
> mechanism in linux-4.14 and later version.
>
> After some investigation, the reason is firmware expects capsules in a
> contiguous virtual space and this assumption is not satisfied in recent
> linux versions.
>
> Ge Song (2):
>   Revert "efi/capsule-loader: Use page addresses rather than struct page
>     pointers"
>   efi/capsule-loader: Request a contiguous virtual space for capsules
>
>  drivers/firmware/efi/capsule-loader.c | 23 ++++++++++++++---------
>  drivers/firmware/efi/capsule.c        |  7 +++----
>  include/linux/efi.h                   |  4 ++--
>  3 files changed, 19 insertions(+), 15 deletions(-)
>

-- 
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.