Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755685AbdLUXNx (ORCPT ); Thu, 21 Dec 2017 18:13:53 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47554 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755563AbdLUXNn (ORCPT ); Thu, 21 Dec 2017 18:13:43 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1061D600C1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 21 Dec 2017 15:13:41 -0800 From: Stephen Boyd To: Gregory CLEMENT Cc: Mike Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?iso-8859-1?Q?Miqu=E8l?= Raynal , Nadav Haklai , Victor Gu , Marcin Wojtas , Wilson Ding , Hua Jing , Neta Zur Hershkovits Subject: Re: [PATCH 0/3] Add DVFS support on CPU clock for Armada 37xx Message-ID: <20171221231341.GC7997@codeaurora.org> References: <20171130134029.20751-1-gregory.clement@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130134029.20751-1-gregory.clement@free-electrons.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 908 Lines: 24 On 11/30, Gregory CLEMENT wrote: > Hi, > > This small series is needed to use DVFS on Armada 37xx. When DVFS is > enabled the CPU clock setting is done using an other set of registers > from the North Bridge Power Management block. > > The series adds the possibility to modify the CPU frequency using the > associate load level matching the target frequency. However > configuring the frequencies for each load is done by the cpufreq > driver submitted in a separate series. > > Obviously having both series (cpufreq and clk) is needed to support > DVFS on Armada 37xx, but there is no dependencies between the series > (for building or at runtime). > Are you relying on the clk API returning an error to detect if DVFS is present or not? Just curious why that part of the code was there. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project