Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755330AbdLUXUn (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Dec 2017 18:20:43 -0500
Received: from mail-wr0-f195.google.com ([209.85.128.195]:44452 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752500AbdLUXUl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Dec 2017 18:20:41 -0500
X-Google-Smtp-Source: ACJfBovwJ67/yxuwN3PEEPFfoitbPoZLNoDQrDWn+xvtClWKRFsJ+L6ni72yyXZDEuFKzdkJ+QFziA==
Date: Thu, 21 Dec 2017 23:20:36 +0000
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
        linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
        Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
        arcml <linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH v2] arch: define weak abort
Message-ID: <20171221232036.GA4643@sudip-laptop>
References: <1513118956-8718-1-git-send-email-sudipm.mukherjee@gmail.com>
 <f098f672-7b51-26ea-c215-2c3edf72e62b@synopsys.com>
 <20171219135559.07104711eb9301f5f40a338f@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171219135559.07104711eb9301f5f40a338f@linux-foundation.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 944
Lines: 32

On Tue, Dec 19, 2017 at 01:55:59PM -0800, Andrew Morton wrote:
> On Tue, 19 Dec 2017 13:39:22 -0800 Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> 

<snip>

> > Hmm, I realize there's a small gotcha with this, when testing with a different 
> > patch from Arnd. This needs an EXPORT_SYMBOL() as well !
> 
> Yup.  This?

Yes, just faced this when I was testing with the reverted patch on m32r.

> 
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: kernel/exit.c: export abort() to modules
> 
> gcc -fisolate-erroneous-paths-dereference can generate calls to abort()
> from modular code too.
> 
> Reported-by: Vineet Gupta <Vineet.Gupta1@synopsys.com>
> Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: "Alexey Brodkin" <Alexey.Brodkin@synopsys.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

--
Regards
Sudip