Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753535AbdLUX0U (ORCPT <rfc822;w@1wt.eu>);
        Thu, 21 Dec 2017 18:26:20 -0500
Received: from mail-pg0-f65.google.com ([74.125.83.65]:36267 "EHLO
        mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750985AbdLUX0R (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 21 Dec 2017 18:26:17 -0500
X-Google-Smtp-Source: ACJfBouNVNi8YZOGpLtiFP0rsM3S42U2CNLONkl2SECoPEkaTZxywdY4XH8a/OFc4lwJTm+0ThzLZg==
Date: Thu, 21 Dec 2017 17:26:14 -0600
From: Rob Herring <robh@kernel.org>
To: Chunyan Zhang <zhang.chunyan@linaro.org>
Cc: Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Chunyan Zhang <zhang.lyra@gmail.com>
Subject: Re: [PATCH 1/5] bindings: regulator: added support for suspend states
Message-ID: <20171221232614.rhrgrpyl2w2lc6bw@rob-hp-laptop>
References: <1513837506-26543-1-git-send-email-zhang.chunyan@linaro.org>
 <1513837506-26543-2-git-send-email-zhang.chunyan@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1513837506-26543-2-git-send-email-zhang.chunyan@linaro.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2028
Lines: 44

On Thu, Dec 21, 2017 at 02:25:02PM +0800, Chunyan Zhang wrote:
> Documented a few new added properties which are used for supporting
> regulator suspend states.

Your commit message should answer why you need this. What problem do you 
have that this solves?

> 
> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
> ---
>  Documentation/devicetree/bindings/regulator/regulator.txt | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt
> index 378f6dc..618a322 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt
> @@ -42,8 +42,15 @@ Optional properties:
>  - regulator-state-[mem/disk] node has following common properties:
>  	- regulator-on-in-suspend: regulator should be on in suspend state.
>  	- regulator-off-in-suspend: regulator should be off in suspend state.
> -	- regulator-suspend-microvolt: regulator should be set to this voltage
> -	  in suspend.
> +	- regulator-suspend-min-microvolt: minimum voltage may be set in
> +	  suspend state.
> +	- regulator-suspend-max-microvolt: maximum voltage may be set in
> +	  suspend state.
> +	- regulator-suspend-microvolt: the default voltage which regulator
> +	  should be set in suspend, this can be adjusted among
> +	  <regulator-suspend-min-microvolt, regulator-suspend-max-microvolt>

Perhaps this should stay a single property with: <target> <min> <max>

Though why would you ever not try to set to the minimum voltage within 
the range of <min> to <max>?

> +	- regulator-changeable-in-suspend: whether the default voltage and
> +	  the regulator on/off in suspend can be changed in runtime.
>  	- regulator-mode: operating mode in the given suspend state.
>  	  The set of possible operating modes depends on the capabilities of
>  	  every hardware so the valid modes are documented on each regulator
> -- 
> 2.7.4
>