Subject: Re: pinctrl-amd: What hardware does it apply to?
To: Tobias Diedrich <tobiasdiedrich@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
        linux-gpio@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>, Ken Xue <Ken.Xue@amd.com>,
        Tobias Diedrich <ranma+kernel@tdiedrich.de>,
        Sudheesh Mavila <sudheesh.mavila@amd.com>,
        platypus-sw <platypus-sw@opengear.com>,
        Timur Tabi <timur@codeaurora.org>
References: <6c675643-45ec-c57f-f1b2-afb25f3e947e@opengear.com>
 <CACRpkdaHj8SFL5AfSkAqDG0mHpgRVbmHuyrhwMUkEH2c4p0VDg@mail.gmail.com>
 <CAOdcoTnpiWkPu4_eOJ6bzUE58PqRHw-y5yHY2T8M3Ymp_2v0MQ@mail.gmail.com>
From: Andrew Cooks <andrew.cooks@opengear.com>
Message-ID: <5dacc682-bc50-b6d1-5a38-e9d571b351c0@opengear.com>
Date: Fri, 22 Dec 2017 11:05:58 +1000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAOdcoTnpiWkPu4_eOJ6bzUE58PqRHw-y5yHY2T8M3Ymp_2v0MQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2017 01:06:14.7467 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ee834ae-9680-4e32-9d25-08d548d83821
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: a6251c26-d21f-4164-a225-1f4eaebf5f9a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR15MB0030
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1331
Lines: 22

Hi Tobias

On 21/12/17 23:06, Tobias Diedrich wrote:

> 
>     > Another driver (gpio-sb8xx) was submitted for upstream inclusion, but was
>     > knocked back with the suggestion that pinctrl is the way forward[3].
> 
>     Hm I cannot follow link [3] right now. And I don't remember the submission :(
>     It doesn't seem to be in my mail archives either.
> 
> 
> FWIW I wrote the gpio-sb8xx driver mostly to allow toggling the (board-specific) APU1 leds and didn't have time to rewrite it for the pinctrl api (also it was more of a "would be neat to have", so I didn't push it much).
> It would actually be neat to have ACPI support for arbitrary leds in some better way (toggling the pinctrl bits could easily be implemented in ACPI if there was some method called to enabled/disable the led).> 
> The coreboot bits were submitted:
> https://github.com/coreboot/coreboot/blob/master/src/mainboard/pcengines/apu1/acpi/leds.asl
> https://github.com/coreboot/coreboot/blob/master/src/mainboard/pcengines/apu1/acpi/gpio.asl
> The latter is specifically asking for "gpio-sb8xx" (or compatible) (this is essentially an ACPI-provided devicetree snippet).

Our ACPI LED support is on a I2C GPIO expander, but looks similar. I'll submit that to coreboot after the holidays. We use the SoC gpios for buttons and other peripherals.

a.