Message-ID: <87a7ybo6em.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <perex@perex.cz>, <tiwai@suse.com>,
        <arnd@arndb.de>, <afd@ti.com>, <robert.jarzmik@free.fr>,
        <supercraig0719@gmail.com>, <jbrunet@baylibre.com>,
        <dannenberg@ti.com>, <romain.perier@collabora.com>,
        <bryce.ferguson@rockwellcollins.com>, <m-stecklein@ti.com>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <ryan.lee.maxim@gmail.com>
Subject: Re: [PATCH] ASoC: max98373: Added Amplifier Driver
In-Reply-To: <1513907030-18441-1-git-send-email-ryans.lee@maximintegrated.com>
References: <1513907030-18441-1-git-send-email-ryans.lee@maximintegrated.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Date: Fri, 22 Dec 2017 02:24:12 +0000
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2017 02:24:12.1602 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: e0cbae93-6eda-41e1-98c5-08d548e317ff
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB1880
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1701
Lines: 51


Hi Ryan

> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
> 
> Created max98373 amplifier driver.
> 
>  .../devicetree/bindings/sound/max98373.txt         |  43 +
>  sound/soc/codecs/Kconfig                           |   5 +
>  sound/soc/codecs/Makefile                          |   2 +
>  sound/soc/codecs/max98373.c                        | 996 +++++++++++++++++++++
>  sound/soc/codecs/max98373.h                        | 225 +++++
>  5 files changed, 1271 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/max98373.txt
>  create mode 100644 sound/soc/codecs/max98373.c
>  create mode 100644 sound/soc/codecs/max98373.h
(snip)
> +struct max98373_priv {
> +	struct regmap *regmap;
> +	struct snd_soc_codec *codec;
> +	unsigned int sysclk;
> +	unsigned int v_slot;
> +	unsigned int i_slot;
> +	unsigned int spkfb_slot;
> +	bool interleave_mode;
> +	unsigned int ch_size;
> +	unsigned int iface;
> +	bool tdm_mode;
> +};

About this max98373->codec.
This user is only max98373_set_clock(), and it is called from
max98373_dai_hw_params().
You are getting *codec from dai->codec in this function,
and max98373 is came from it.
This means, we can remove max98373->codec ?

About max98373->regmap.
You are using devm_regmap_init_i2c(), and keeping it on max98373.
Can you check snd_soc_component_add() which is called from
snd_soc_add_component().
It will set component->regmap if you called devm_regmap_init_i2c().
I think you can use snd_soc_component_read/write instead of regmap_read/write.
Then, we can remove max98373->regmap too ?
Ahh, you want to check Revision ID.
then, snd_soc_component_init_regmap() can help you ?

Best regards
---
Kuninori Morimoto