Date: Fri, 22 Dec 2017 09:41:32 +0530
From: afzal mohammed <afzal.mohd.ma@gmail.com>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
        Peter Zijlstra <peterz@infradead.org>, parri.andrea@gmail.com,
        will.deacon@arm.com, boqun.feng@gmail.com, npiggin@gmail.com,
        dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr,
        linux-kernel@vger.kernel.org, elena.reshetova@intel.com
Subject: Re: Prototype patch for Linux-kernel memory model
Message-ID: <20171222041132.GA5354@afzalpc>
References: <20171114075925.apzztfksn4f4y5ue@hirez.programming.kicks-ass.net>
 <Pine.LNX.4.44L0.1711141016340.1796-100000@iolanthe.rowland.org>
 <20171114171505.GS3624@linux.vnet.ibm.com>
 <20171115163749.GA8555@linux.vnet.ibm.com>
 <20171220113145.GA5082@afzalpc>
 <20171220164538.GL7829@linux.vnet.ibm.com>
 <20171221033055.GA3944@afzalpc>
 <20171221161502.GX7829@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171221161502.GX7829@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1280
Lines: 32

Hi,

On Thu, Dec 21, 2017 at 08:15:02AM -0800, Paul E. McKenney wrote:
> On Thu, Dec 21, 2017 at 09:00:55AM +0530, afzal mohammed wrote:

> > Since it is now mentioned that r1 can have final value of 0, though it
> > is understood, it might make things crystal clear and for the sake of
> > completeness to also show the non-automatic variable x being
> > initialized to 0.
> 
> Here we rely on the C-language and Linux-kernel convention that global
> variables that are not explicitly initialized are initialized to zero.
> (Also the documented behavior of the litmus tests and the herd tool that
> uses them.)  So that part should be OK as is.

Okay, that was suggested to bring parity with some of the examples in
explanation.txt, where global variables are explicitly initalized to
zero, that unconsciously made me feel that litmus tests also follow
that pattern, but checking again realize that litmus tests are not so.

> 
> Nevertheless, thank you for your review and comments!

Thanks for taking the effort to reply.

> Have you installed and run the herd tool?  Doing so would allow you
> to experiment with changes to the litmus tests.

Yes, i installed herd tool and then i was at a loss :(, so started
re-reading the documentation, yet to run any of the tests.

afzal