Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751733AbdLVGY6 (ORCPT ); Fri, 22 Dec 2017 01:24:58 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:4959 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750995AbdLVGYz (ORCPT ); Fri, 22 Dec 2017 01:24:55 -0500 X-UUID: f1daaca571544b89ae0c6f006788c45b-20171222 Message-ID: <1513923888.30687.7.camel@mtkswgap22> Subject: Re: [PATCH] arm: dts: mt7623: enable all four available UARTs on bananapi-r2 From: Sean Wang To: CC: , , , , , Date: Fri, 22 Dec 2017 14:24:48 +0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2005 Lines: 76 On Fri, 2017-12-22 at 14:06 +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > On bpi-r2 board, totally there're four uarts which we usually called > uart[0-3] helpful to extend slow I/O devices. Among those ones, uart2 has > dedicated pin slot which is used to conolse log. uart[0-1] appear at the Hi, Matthias Could you help to fix the misspelling "conolse" with "console" when you merge the patch ? Sean > 40-pins connector and uart3 has no pinout, but just has test points (TP47 > for TX and TP48 for RX, respectively) nearby uart2. Also, some missing > pinctrl is being complemented for those devices. > > Signed-off-by: Sean Wang > --- > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index 7bf5aa2..64bf5db 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -409,6 +409,20 @@ > ; > }; > }; > + > + uart2_pins_a: uart@2 { > + pins_dat { > + pinmux = , > + ; > + }; > + }; > + > + uart3_pins_a: uart@3 { > + pins_dat { > + pinmux = , > + ; > + }; > + }; > }; > > &pwm { > @@ -454,16 +468,24 @@ > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0_pins_a>; > - status = "disabled"; > + status = "okay"; > }; > > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&uart1_pins_a>; > - status = "disabled"; > + status = "okay"; > }; > > &uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart2_pins_a>; > + status = "okay"; > +}; > + > +&uart3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart3_pins_a>; > status = "okay"; > }; >