Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755761AbdLVITV convert rfc822-to-8bit (ORCPT ); Fri, 22 Dec 2017 03:19:21 -0500 Received: from szxga02-in.huawei.com ([45.249.212.188]:2493 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751390AbdLVITS (ORCPT ); Fri, 22 Dec 2017 03:19:18 -0500 From: Lipengcheng To: Greg KH CC: "balbi@kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Lidongpo Subject: RE: [usb gadget]use dev_kfree_skb_irq instead of dev_kfree_skb Thread-Topic: [usb gadget]use dev_kfree_skb_irq instead of dev_kfree_skb Thread-Index: AQHTevl9Seqe/V5wW0CK0rnVKZYwjKNPBFvA Date: Fri, 22 Dec 2017 08:19:07 +0000 Message-ID: <637796ED17F7774FB27D6AAE3C6951584B38C42B@dggeml508-mbx.china.huawei.com> References: <20171222075005.GA18229@kroah.com> In-Reply-To: <20171222075005.GA18229@kroah.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.222.17] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 36 Hi, > -----Original Message----- > From: Greg KH [mailto:gregkh@linuxfoundation.org] > Sent: Friday, December 22, 2017 3:50 PM > To: Lipengcheng > Cc: balbi@kernel.org; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [usb gadget]use dev_kfree_skb_irq instead of dev_kfree_skb > > On Fri, Dec 22, 2017 at 03:43:15PM +0800, lpc.li wrote: > > Hi, > > Ethernet Gadget (with CDC Ethernet support) and RNDIS support, device > > is Hisilicon asic and host is PC Windows. Howerver, it has one > > warning. In the rndis_add_header of the file f_rndis.c, > > dev_kfree_skb_irq replaces dev_kfree_skb. And the waning is > > eliminated. I think we can't use dev_kfree_skb in irq disable context, > > because spin_lock_irqsave make sure we are always in irq disable > > context, use dev_kfree_skb_irq instead of dev_kfree_skb is better than > > dev_kfree_skb_any. > > Can you make up a patch for this please? Ok. > > > > > #<--CO------------[ cut here ]------------ > > WARNING: CPU: 0 PID: 22 at kernel/softirq.c:146 > > __local_bh_enable_ip+0x8c/0xb4() Modules linked in: g_ether usb_f_ecm > > usb_f_rndis u_ether libcomposite configfs udc_hisi hi_gpio(O) hifb(O) > > hi3559_tde(PO) hi3559_sys(PO) hi3559_base(PO) hi_osal(O) hi_ipcm(O) > > CPU: 0 PID: 22 Comm: kworker/0:1 Tainted: P O 3.18.20 #1 > > Note, 3.18 is _VERY_ old, are you sure this isn't resolved in a modern and secure kernel release? :) The problem still exists in a modern and secure kernel release > > thanks, > > greg k-h