Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755942AbdLVIfP (ORCPT ); Fri, 22 Dec 2017 03:35:15 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:41581 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbdLVIfK (ORCPT ); Fri, 22 Dec 2017 03:35:10 -0500 Date: Fri, 22 Dec 2017 09:35:08 +0100 From: Maxime Ripard To: Emmanuel Vadot Cc: Kyle Evans , Mark Rutland , devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, Russell King , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Srinivas Kandagatla , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t Message-ID: <20171222083508.dfcp6egfvxykmogg@flea.lan> References: <20171219210523.10428-1-kevans91@ksu.edu> <20171221145512.llxvzkcrjpquhczi@flea.lan> <20171221152630.2vf57x5o2yi5sv3n@flea.lan> <20171221190903.56ebae536acf51401c63802c@bidouilliste.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lqioqqfwapxkw3qv" Content-Disposition: inline In-Reply-To: <20171221190903.56ebae536acf51401c63802c@bidouilliste.com> User-Agent: NeoMutt/20171208 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2935 Lines: 81 --lqioqqfwapxkw3qv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 21, 2017 at 07:09:03PM +0100, Emmanuel Vadot wrote: >=20 > Hi Maxime, >=20 > On Thu, 21 Dec 2017 16:26:30 +0100 > Maxime Ripard wrote: >=20 > > Hi, > >=20 > > On Thu, Dec 21, 2017 at 09:19:24AM -0600, Kyle Evans wrote: > > > On Thu, Dec 21, 2017 at 8:55 AM, Maxime Ripard > > > wrote: > > > > Hi Kyle, > > > > > > > > On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@ksu.edu wrote: > > > >> Allwinner a83t has a 1 KB sid block with efuse for security rootke= y and > > > >> thermal calibration data, add node to describe it. > > > >> > > > >> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is > > > >> supported in an external driver for FreeBSD. > > > >> > > > >> Signed-off-by: Kyle Evans > > > > > > > > The patch looks fine in itself, but we've had a number of issues wi= th > > > > the register layout (and access patterns) in the past, so I'd rather > > > > have something that works in Linux too if possible. > > >=20 > > > I have a patch that I think should make it work fine on Linux [1], but > > > I'm afraid I have little to no capability to test it myself and so I > > > did not add it as well. > > >=20 > > > I do know that the rootkey is offset 0x200 into the given space [2], > > > as is the case with the H3, and that the readout quirk is not needed. > > > I wasn't 100% sure that the a83t has 2Kbit worth of efuse space as the > > > H3, but I do know that thermal data can be found at 0x34 and 0x38 in > > > this space. > >=20 > > Then maybe we should leave it aside until someone takes some time on > > the A83t.=20 >=20 > Take some time on the Linux driver and do not apply this patch for > now you mean ? Yep. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --lqioqqfwapxkw3qv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlo8w5oACgkQ0rTAlCFN r3TUgw/8CG9FBzWvRYL4r/kNS+fNLsWm4dHA29U0r+XHuDlknnn7Aiw3J+EU3oJB MNcOmm1mXafG6FD+yCW5GzGD1gkyKzABsZd33I9/pRi40njOIFhReaggbBahwcc8 Iu1ayoxZm8O1p8DP3lmq6q/kIPh5VwgQd/JfX5A0P/WIueOMiDkYZwT/FUV+xmlb 9nfLeanVrPgmPi7vfBcSLjTzBXi+bL1Q0Io6gMkk1hrh1cT5FoumceuNkjWFwIaP L87FTEBDJy1un32zd/FhhsYqQafFBtjiQPy1HYN2t0/+SaS6DS/JH0NvJKOpkej8 EZR3JdqQZeBuH+ERrxD9UAdaD23ZCTJ7f5EtoDepKOBqO0EITCpvRmnl5kTBLmfO rc0rMNalwJZpLE332FqHn8Yl2F0Dr4mrmpBjIrfjgnJd1R8lrP65f8+0Uj19T037 UuOtccdC8iH46HCrKbskhZVUNaCohXICEbyIjePCIlo/D4MfO57marwxXrchi5Vc bTuwwDCH003cdbNb8PwOT1CmShlsQUDFc0Uw1ZZKydk9lVOOiYttauNwwWBUMA3G ocd1Sp6RJSDwxFBtFXHa7PrYbvlWYV2qqdHWiTiJK+hmubNI+KyOyQ7otG2xrVOZ Ga+ZowX3AFjHq0q82s58/1hJR2RNlFsqxVd9wcadRJ+BrLpGXYE= =7ZDE -----END PGP SIGNATURE----- --lqioqqfwapxkw3qv--