Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755863AbdLVIjp (ORCPT <rfc822;w@1wt.eu>);
        Fri, 22 Dec 2017 03:39:45 -0500
Received: from mail-wr0-f177.google.com ([209.85.128.177]:34575 "EHLO
        mail-wr0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752689AbdLVIjm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 22 Dec 2017 03:39:42 -0500
X-Google-Smtp-Source: ACJfBos6+aBr5bsSz+6OI3QujVzrgB/R2rdsyRtwxSUEXrsEU7HN7uCPp97O/eADo0oqlyIfLaTGKaOvEggWECsxOsE=
MIME-Version: 1.0
In-Reply-To: <1513907030-18441-1-git-send-email-ryans.lee@maximintegrated.com>
References: <1513907030-18441-1-git-send-email-ryans.lee@maximintegrated.com>
From: Philippe Ombredanne <pombredanne@nexb.com>
Date: Fri, 22 Dec 2017 09:39:00 +0100
Message-ID: <CAOFm3uH3+UsSZ7DgDk9AYRb8K7GjKUNwchGW3_hxD3DMOidjpg@mail.gmail.com>
Subject: Re: [PATCH] ASoC: max98373: Added Amplifier Driver
To: Ryan Lee <ryans.lee@maximintegrated.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Arnd Bergmann <arnd@arndb.de>, afd@ti.com, robert.jarzmik@free.fr,
        supercraig0719@gmail.com, jbrunet@baylibre.com, dannenberg@ti.com,
        Romain Perier <romain.perier@collabora.com>,
        bryce.ferguson@rockwellcollins.com, kuninori.morimoto.gx@renesas.com,
        m-stecklein@ti.com, ALSA <alsa-devel@alsa-project.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, ryan.lee.maxim@gmail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1057
Lines: 40

Ryan,

On Fri, Dec 22, 2017 at 2:43 AM, Ryan Lee <ryans.lee@maximintegrated.com> wrote:
> Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
> ---
>
> Created max98373 amplifier driver.
>

<snip>

> --- /dev/null
> +++ b/sound/soc/codecs/max98373.c
> @@ -0,0 +1,996 @@
> +/*
> + * max98373.c  --  MAX98373 ALSA Soc Audio driver
> + *
> + * Copyright (C) 2017 Maxim Integrated Products
> + * Author: Ryan Lee <ryans.lee@maximintegrated.com>
> + *
> + *  This program is free software; you can redistribute  it and/or modify it
> + *  under  the terms of  the GNU General  Public License as published by the
> + *  Free Software Foundation;  either version 2 of the  License, or (at your
> + *  option) any later version.
> + */

Have you considered using the new SPDX tags instead of this fine but
long legalese?

And if other contributors in your team could follow suit and you could
spread the word that would be even better!

See Thomas doc patches [1] for details.
Thanks!

[1] https://lkml.org/lkml/2017/12/4/934

-- 
Cordially
Philippe Ombredanne