Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758167AbdLVJdV (ORCPT ); Fri, 22 Dec 2017 04:33:21 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39328 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965314AbdLVJCr (ORCPT ); Fri, 22 Dec 2017 04:02:47 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alex Shi , Jens Wiklander , andi@linux-stable.l.notmuch.email Subject: [PATCH 4.14 100/159] optee: fix invalid of_node_put() in optee_driver_init() Date: Fri, 22 Dec 2017 09:46:25 +0100 Message-Id: <20171222084629.147924951@linuxfoundation.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171222084623.668990192@linuxfoundation.org> References: <20171222084623.668990192@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 35 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jens Wiklander commit f044113113dd95ba73916bde10e804d3cdfa2662 upstream. The first node supplied to of_find_matching_node() has its reference counter decreased as part of call to that function. In optee_driver_init() after calling of_find_matching_node() it's invalid to call of_node_put() on the supplied node again. So remove the invalid call to of_node_put(). Reported-by: Alex Shi Signed-off-by: Jens Wiklander Cc: Signed-off-by: Greg Kroah-Hartman --- drivers/tee/optee/core.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -590,7 +590,6 @@ static int __init optee_driver_init(void return -ENODEV; np = of_find_matching_node(fw_np, optee_match); - of_node_put(fw_np); if (!np) return -ENODEV;