Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933266AbdLVJfD (ORCPT ); Fri, 22 Dec 2017 04:35:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:60564 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757875AbdLVJeJ (ORCPT ); Fri, 22 Dec 2017 04:34:09 -0500 Date: Fri, 22 Dec 2017 10:34:07 +0100 From: Michal Hocko To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Shakeel Butt , Paolo Bonzini , Sasha Levin Subject: Re: [PATCH 4.14 108/159] kvm, mm: account kvm related kmem slabs to kmemcg Message-ID: <20171222093407.GN4831@dhcp22.suse.cz> References: <20171222084623.668990192@linuxfoundation.org> <20171222084629.570989756@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171222084629.570989756@linuxfoundation.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2215 Lines: 66 On Fri 22-12-17 09:46:33, Greg KH wrote: > 4.14-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Shakeel Butt > > > [ Upstream commit 46bea48ac241fe0b413805952dda74dd0c09ba8b ] > > The kvm slabs can consume a significant amount of system memory > and indeed in our production environment we have observed that > a lot of machines are spending significant amount of memory that > can not be left as system memory overhead. Also the allocations > from these slabs can be triggered directly by user space applications > which has access to kvm and thus a buggy application can leak > such memory. So, these caches should be accounted to kmemcg. > > Signed-off-by: Shakeel Butt > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman The patch is not marked for stable, neither it fixes an existing bug. It is a nice to have thing for sure but I am wondering how this got through stable-filter. > --- > arch/x86/kvm/mmu.c | 4 ++-- > virt/kvm/kvm_main.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -5476,13 +5476,13 @@ int kvm_mmu_module_init(void) > > pte_list_desc_cache = kmem_cache_create("pte_list_desc", > sizeof(struct pte_list_desc), > - 0, 0, NULL); > + 0, SLAB_ACCOUNT, NULL); > if (!pte_list_desc_cache) > goto nomem; > > mmu_page_header_cache = kmem_cache_create("kvm_mmu_page_header", > sizeof(struct kvm_mmu_page), > - 0, 0, NULL); > + 0, SLAB_ACCOUNT, NULL); > if (!mmu_page_header_cache) > goto nomem; > > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4018,7 +4018,7 @@ int kvm_init(void *opaque, unsigned vcpu > if (!vcpu_align) > vcpu_align = __alignof__(struct kvm_vcpu); > kvm_vcpu_cache = kmem_cache_create("kvm_vcpu", vcpu_size, vcpu_align, > - 0, NULL); > + SLAB_ACCOUNT, NULL); > if (!kvm_vcpu_cache) { > r = -ENOMEM; > goto out_free_3; > -- Michal Hocko SUSE Labs