Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757392AbdLVKnq (ORCPT ); Fri, 22 Dec 2017 05:43:46 -0500 Received: from mx2.suse.de ([195.135.220.15]:38297 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756686AbdLVKng (ORCPT ); Fri, 22 Dec 2017 05:43:36 -0500 Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series To: Alexandre Belloni Cc: =?UTF-8?Q?T=c3=bcrk=2c_Jan?= , "'Rob Herring'" , Mark Rutland , Thierry Reding , David Airlie , Russell King , Shawn Guo , Sascha Hauer , Fabio Estevam , Kevin Hilman , Maxime Ripard , SZ Lin , Greg Kroah-Hartman , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , LinuxArmKernelMailingListe References: <95F51F4B902CAC40AF459205F6322F01B7FDFECC3C@BMK019S01.emtrion.local> <20171222104028.GC18255@piout.net> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Linux GmbH Message-ID: Date: Fri, 22 Dec 2017 11:43:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171222104028.GC18255@piout.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2507 Lines: 70 Hi, Am 22.12.2017 um 11:40 schrieb Alexandre Belloni: > On 22/12/2017 at 11:34:31 +0100, Türk, Jan wrote: >>>> diff --git a/arch/arm/boot/dts/imx6q-emcon.dtsi b/arch/arm/boot/dts/imx6q- >>> emcon.dtsi >>>> new file mode 100644 >>>> index 000000000000..64fc0cd74c05 >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/imx6q-emcon.dtsi >>>> @@ -0,0 +1,37 @@ >>>> +/* >>>> + * Copyright (C) 2017 emtrion GmbH >>>> + * Author: Jan Tuerk >>>> + * >>>> + * The code contained herein is licensed under the GNU General Public >>>> + * License. You may obtain a copy of the GNU General Public License >>>> + * Version 2 or later at the following locations: >>>> + * >>>> + * http://www.opensource.org/licenses/gpl-license.html >>>> + * http://www.gnu.org/copyleft/gpl.html >>> >>> You don't need this if... >> >> I've got a little different point of view on this since the OSS Europe 2017 - part of gpl2 following. >> >> GPLv2-Para1 (=>highlighted<=) : >> 1. You may copy and distribute verbatim copies of the Program's source code as you receive it, in any medium, >> provided that you conspicuously and appropriately publish on each copy an >> => appropriate copyright notice and disclaimer of warranty; <= >> keep intact all the notices that refer to this License and to the absence of any warranty; >> and give any other recipients of the Program a copy of this License along with the Program. >> >> After reviewing this I think apparently I should include the Warranty disclaimer as well. >> Examples could be found in: >> arch/arm/boot/dts/imx6q-tbs2910.dts >> and >> arch/arm/boot/dts/imx6q-zii-rdu2.dts >> > > The license is already fully included in COPYING with the warranty > disclaimer. > >>> >>>> + * >>>> + * SPDX-License-Identifier: GPL-2.0 >>> >>> You have this. >>> >>> Also, the rules around this are getting a bit stricter saying the SPDX >>> tag should be the first line of the file using a C++ style comment. >>> >> I'll change it for v3 of this patch however it will end up like this: >> //SPDX-License... > > That should be /* SPDX-License */, // is for c files. Got any reference for that? Since we're using the C preprocessor before feeding them to dtc, we can use the same // style for both, builds fine. Only for my private DT overlay files that I use directly with dtc I couldn't adopt that style. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)