Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756313AbdLVK46 (ORCPT ); Fri, 22 Dec 2017 05:56:58 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47939 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbdLVK4x (ORCPT ); Fri, 22 Dec 2017 05:56:53 -0500 Date: Fri, 22 Dec 2017 11:56:42 +0100 From: Alexandre Belloni To: Andreas =?iso-8859-1?Q?F=E4rber?= , Philippe Ombredanne Cc: =?iso-8859-1?B?VPxyayw=?= Jan , "'Rob Herring'" , Mark Rutland , Thierry Reding , David Airlie , Russell King , Shawn Guo , Sascha Hauer , Fabio Estevam , Kevin Hilman , Maxime Ripard , SZ Lin , Greg Kroah-Hartman , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , LinuxArmKernelMailingListe Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series Message-ID: <20171222105642.GD18255@piout.net> References: <95F51F4B902CAC40AF459205F6322F01B7FDFECC3C@BMK019S01.emtrion.local> <20171222104028.GC18255@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 32 + Philippe On 22/12/2017 at 11:43:33 +0100, Andreas F?rber wrote: > >> I'll change it for v3 of this patch however it will end up like this: > >> //SPDX-License... > > > > That should be /* SPDX-License */, // is for c files. > > Got any reference for that? Since we're using the C preprocessor before > feeding them to dtc, we can use the same // style for both, builds fine. > > Only for my private DT overlay files that I use directly with dtc I > couldn't adopt that style. > The doc states: If a specific tool cannot handle the standard comment style, then the appropriate comment mechanism which the tool accepts shall be used. This is the reason for having the "/\* \*/" style comment in C header files. I interpreted that as dtc doesn't handle // comments, use /**/ But I agree it also states: .dts{i}: // SPDX-License-Identifier: So I think we will end up with a mix of both. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com