Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755690AbdLVNgj (ORCPT ); Fri, 22 Dec 2017 08:36:39 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:53789 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063AbdLVNgi (ORCPT ); Fri, 22 Dec 2017 08:36:38 -0500 Date: Fri, 22 Dec 2017 05:36:34 -0800 From: Matthew Wilcox To: Josh Triplett Cc: Ross Zwisler , linux-kernel@vger.kernel.org, Dave Hansen , linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH 2/2] Introduce __cond_lock_err Message-ID: <20171222133634.GE6401@bombadil.infradead.org> References: <20171219165823.24243-1-willy@infradead.org> <20171219165823.24243-2-willy@infradead.org> <20171221214810.GC9087@linux.intel.com> <20171222011000.GB23624@bombadil.infradead.org> <20171222042120.GA18036@localhost> <20171222123112.GA6401@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171222123112.GA6401@bombadil.infradead.org> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 18 On Fri, Dec 22, 2017 at 04:31:12AM -0800, Matthew Wilcox wrote: > On Thu, Dec 21, 2017 at 08:21:20PM -0800, Josh Triplett wrote: > > On Thu, Dec 21, 2017 at 05:10:00PM -0800, Matthew Wilcox wrote: > > > Yes, but this define is only #if __CHECKER__, so it doesn't matter what we > > > return as this code will never run. > > > > It does matter slightly, as Sparse does some (very limited) value-based > > analyses. Let's future-proof it. > > > > > That said, if sparse supports the GNU syntax of ?: then I have no > > > objection to doing that. > > > > Sparse does support that syntax. > > Great, I'll fix that and resubmit. Except the context imbalance warning comes back if I do. This is sparse 0.5.1 (Debian's 0.5.1-2 package).