Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756375AbdLVPu2 (ORCPT ); Fri, 22 Dec 2017 10:50:28 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:35025 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466AbdLVPuY (ORCPT ); Fri, 22 Dec 2017 10:50:24 -0500 X-Google-Smtp-Source: ACJfBot84ZkKm9ai4Eo6WWSBTFUmRyLmlEJ4o6OdCxFu+9cIejoEgHYeMCf0um2JFXtMN9s3LqMS9wqMgiqKJGwKV/0= MIME-Version: 1.0 In-Reply-To: <5851a90c-b334-9b28-d3b3-8eba7c933222@codeaurora.org> References: <1513680554-5682-1-git-send-email-ge.song@hxt-semitech.com> <5851a90c-b334-9b28-d3b3-8eba7c933222@codeaurora.org> From: Ard Biesheuvel Date: Fri, 22 Dec 2017 15:50:23 +0000 Message-ID: Subject: Re: [PATCH 0/2] Make capsules in a contiguous virtual space To: Richard Ruigrok Cc: Ge Song , Matt Fleming , linux-efi@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 37 On 21 December 2017 at 21:47, Richard Ruigrok wrote: > Please tested-by > Tested on Centiq, applied on v4.15-rc4. > This fixes the regression introduced in 4.13 where the capsule is no longer passed in contiguous virtual memory. > > On 12/19/2017 3:49 AM, Ge Song wrote: >> Recently we found it failed to update firmware through capsule update >> mechanism in linux-4.14 and later version. >> >> After some investigation, the reason is firmware expects capsules in a >> contiguous virtual space and this assumption is not satisfied in recent >> linux versions. >> >> Ge Song (2): >> Revert "efi/capsule-loader: Use page addresses rather than struct page >> pointers" >> efi/capsule-loader: Request a contiguous virtual space for capsules >> Thanks for the patches (and for the tested-by). I will look into this, but I'd like to try to fix this without breaking the quirk we did for Quark. >> drivers/firmware/efi/capsule-loader.c | 23 ++++++++++++++--------- >> drivers/firmware/efi/capsule.c | 7 +++---- >> include/linux/efi.h | 4 ++-- >> 3 files changed, 19 insertions(+), 15 deletions(-) >> > > -- > Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. > Qualcomm Technologies, Inc. is a member of the > Code Aurora Forum, a Linux Foundation Collaborative Project. >