Date: Fri, 22 Dec 2017 09:37:48 -0800
From: Brian Norris <briannorris@chromium.org>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
        Matthias Kaehlcke <mka@chromium.org>,
        "Ghorai, Sukumar" <sukumar.ghorai@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        "Bag, Amit K" <amit.k.bag@intel.com>, Oliver Neukum <oneukum@suse.com>,
        Marcel Holtmann <marcel@holtmann.org>,
        Todd Broch <tbroch@chromium.org>, Rajat Jain <rajatja@chromium.org>,
        Miao Chou <mcchou@chromium.org>,
        "Rao Pv, Sadashiva" <sadashiva.rao.pv@intel.com>
Subject: Re: [PATCH 4.4 009/115] Bluetooth: btusb: driver to enable the
 usb-wakeup feature
Message-ID: <20171222173747.GB127515@google.com>
References: <20171221182639.GA30333@roeck-us.net>
 <D73ECEF0C711E34A8F972E4B87F5400579901388@ORSMSX114.amr.corp.intel.com>
 <20171221185830.GA219523@google.com>
 <D73ECEF0C711E34A8F972E4B87F54005799013B0@ORSMSX114.amr.corp.intel.com>
 <20171221191057.GA222103@google.com>
 <20171221200457.GB24020@roeck-us.net>
 <20171221204618.GB29509@kroah.com>
 <20171221205057.GC29509@kroah.com>
 <20171221213941.GD24020@roeck-us.net>
 <20171222074828.GA15565@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171222074828.GA15565@kroah.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 20

On Fri, Dec 22, 2017 at 08:48:28AM +0100, Greg Kroah-Hartman wrote:
> I've reverted this from 4.4 and 4.9-stable, but note that this was

Thanks!

> included in 4.14-rc1, so something needs to be done in Linus's tree to
> resolve this issue, otherwise people will hit this as a regression when
> moving to 4.14 or newer.

Well, I wouldn't object to reverting it in Linus' tree too, since AFAIK,
this is something that can be configured by user-space policy, no? And
that way, no user space is surprised by the sudden additional
requirements on managing bluetooth wakeup.

I'm not intimately familiar with bluetooth though; I just (think I) know
a regression when I see one, as well as the difference between a feature
addition and a bugfix. But I'm not sure I'm the authority on what to do
with this feature. Many who are CC'd should know better.

Brian