Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756643AbdLVScX (ORCPT ); Fri, 22 Dec 2017 13:32:23 -0500 Received: from mga11.intel.com ([192.55.52.93]:27206 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755458AbdLVScU (ORCPT ); Fri, 22 Dec 2017 13:32:20 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,442,1508828400"; d="scan'208";a="189081794" Date: Fri, 22 Dec 2017 20:32:16 +0200 From: Jarkko Sakkinen To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, James Ettle , Hans de Goede , Azhar Shaikh , Arnd Bergmann , Peter Huewe , Jason Gunthorpe , Greg Kroah-Hartman , linux-integrity@vger.kernel.org Subject: Re: [PATCH 3/4] tpm: follow coding style for variable declaration in tpm_tis_core_init() Message-ID: <20171222183216.pdwajmnxexyocxol@linux.intel.com> References: <20171220113538.16099-1-javierm@redhat.com> <20171220113538.16099-4-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171220113538.16099-4-javierm@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1143 Lines: 34 On Wed, Dec 20, 2017 at 12:35:37PM +0100, Javier Martinez Canillas wrote: > The coding style says "use just one data declaration per line (no commas > for multiple data declarations)" so follow this convention. > > Suggested-by: Jarkko Sakkinen > Signed-off-by: Javier Martinez Canillas > --- > > drivers/char/tpm/tpm_tis_core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c > index 09da1e1adc40..534cd46fdfae 100644 > --- a/drivers/char/tpm/tpm_tis_core.c > +++ b/drivers/char/tpm/tpm_tis_core.c > @@ -798,7 +798,9 @@ int tpm_tis_core_init(struct device *dev, struct tpm_tis_data *priv, int irq, > const struct tpm_tis_phy_ops *phy_ops, > acpi_handle acpi_dev_handle) > { > - u32 vendor, intfcaps, intmask; > + u32 vendor; > + u32 intfcaps; > + u32 intmask; > u8 rid; > int rc, probe; > struct tpm_chip *chip; > -- > 2.14.3 > Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen /Jarkko