Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756776AbdLVVnc (ORCPT ); Fri, 22 Dec 2017 16:43:32 -0500 Received: from mail.ispras.ru ([83.149.199.45]:58724 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756149AbdLVVn2 (ORCPT ); Fri, 22 Dec 2017 16:43:28 -0500 From: Alexey Khoroshilov To: Stefan Agner , Boris Brezillon Cc: Alexey Khoroshilov , Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] mtd: nand: vf610: fix error handling in vf610_nfc_probe() Date: Sat, 23 Dec 2017 00:43:14 +0300 Message-Id: <1513978994-5739-1-git-send-email-khoroshilov@ispras.ru> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 798 Lines: 27 vf610_nfc_probe() misses error handling of mtd_device_register(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/mtd/nand/vf610_nfc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c index 8037d4b48a05..a4c181af74b3 100644 --- a/drivers/mtd/nand/vf610_nfc.c +++ b/drivers/mtd/nand/vf610_nfc.c @@ -782,7 +782,10 @@ static int vf610_nfc_probe(struct platform_device *pdev) platform_set_drvdata(pdev, mtd); /* Register device in MTD */ - return mtd_device_register(mtd, NULL, 0); + err = mtd_device_register(mtd, NULL, 0); + if (err) + goto error; + return 0; error: of_node_put(nand_get_flash_node(chip)); -- 2.7.4