Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756953AbdLVWAI convert rfc822-to-8bit (ORCPT ); Fri, 22 Dec 2017 17:00:08 -0500 Received: from mga14.intel.com ([192.55.52.115]:40860 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756404AbdLVWAE (ORCPT ); Fri, 22 Dec 2017 17:00:04 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,442,1508828400"; d="scan'208";a="4687943" From: "Brown, Aaron F" To: "Neftin, Sasha" , Benjamin Poirier , "Kirsher, Jeffrey T" CC: Ben Hutchings , Gabriel C , "netdev@vger.kernel.org" , Christian Hesse , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "intel-wired-lan@lists.osuosl.org" Subject: RE: [Intel-wired-lan] [PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value. Thread-Topic: [Intel-wired-lan] [PATCH] e1000e: Fix e1000_check_for_copper_link_ich8lan return value. Thread-Index: AQHTclGVAQt/0wPrhkaLfUT7VL5ObKNN81mAgAIILIA= Date: Fri, 22 Dec 2017 22:00:00 +0000 Message-ID: <309B89C4C689E141A5FF6A0C5FB2118B8C71D3A3@ORSMSX103.amr.corp.intel.com> References: <20171208114552.5f517fd3@leda> <20171211072640.7935-1-bpoirier@suse.com> <441de43f-4234-7616-2879-7e2e31a8d522@intel.com> In-Reply-To: <441de43f-4234-7616-2879-7e2e31a8d522@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzYxNTk0NjQtZDdlMi00NzUzLTg0OTUtNTliMDU4ZWNlMDBjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNISG92ZDFkKzBuWWdWbmV0NERIYVpzMmFibkplYXNuYzV5VVpxNnJmTm89In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1821 Lines: 42 > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On > Behalf Of Neftin, Sasha > Sent: Wednesday, December 20, 2017 10:57 PM > To: Benjamin Poirier ; Kirsher, Jeffrey T > > Cc: Ben Hutchings ; Gabriel C > ; netdev@vger.kernel.org; Christian Hesse > ; stable@vger.kernel.org; linux-kernel@vger.kernel.org; > intel-wired-lan@lists.osuosl.org > Subject: Re: [Intel-wired-lan] [PATCH] e1000e: Fix > e1000_check_for_copper_link_ich8lan return value. > > On 11/12/2017 9:26, Benjamin Poirier wrote: > > e1000e_check_for_copper_link() and > e1000_check_for_copper_link_ich8lan() > > are the two functions that may be assigned to mac.ops.check_for_link > when > > phy.media_type == e1000_media_type_copper. Commit 19110cfbb34d > ("e1000e: > > Separate signaling for link check/link up") changed the meaning of the > > return value of check_for_link for copper media but only adjusted the first > > function. This patch adjusts the second function likewise. > > > > Reported-by: Christian Hesse > > Reported-by: Gabriel C > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=198047 > > Fixes: 19110cfbb34d ("e1000e: Separate signaling for link check/link up") > > Tested-by: Christian Hesse > > Signed-off-by: Benjamin Poirier > > --- > > drivers/net/ethernet/intel/e1000e/ich8lan.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > Tested-by: Aaron Brown > Acked by sasha.neftin@intel.com > > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan