Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932114AbdLWBiB (ORCPT ); Fri, 22 Dec 2017 20:38:01 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42291 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757080AbdLWBh6 (ORCPT ); Fri, 22 Dec 2017 20:37:58 -0500 X-Greylist: delayed 516 seconds by postgrey-1.27 at vger.kernel.org; Fri, 22 Dec 2017 20:37:58 EST X-ME-Sender: Date: Fri, 22 Dec 2017 23:29:17 -0200 From: Henrique de Moraes Holschuh To: Andy Shevchenko Cc: SF Markus Elfring , ibm-acpi-devel@lists.sourceforge.net, Platform Driver , Andy Shevchenko , Darren Hart , Henrique de Moraes Holschuh , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations Message-ID: <20171223012917.vbe6mvz4yltiyws3@khazad-dum.debian.net> References: <81459d11-693a-eb51-9173-9c189677f422@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint1: 4096R/0x0BD9E81139CB4807: C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 810 Lines: 26 On Tue, 19 Dec 2017, Andy Shevchenko wrote: > On Mon, Dec 18, 2017 at 11:26 PM, SF Markus Elfring > wrote: > > From: Markus Elfring > > Date: Mon, 18 Dec 2017 22:23:45 +0100 > > > > Two update suggestions were taken into account > > from static source code analysis. > > > > Markus Elfring (2): > > Delete an error message for a failed memory allocation in three functions > > This one is questionable since it prints error messages at ->init() stage. > I would rather not touch this. > > > Improve a size determination in tpacpi_new_rfkill() > > Doesn't make any sense right now. One style over the other. > Nothing gets better or worth at this point. > > Sorry, but NAK for both. Agreed. NAK from me as well. -- Henrique Holschuh