Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbdLWHwH (ORCPT ); Sat, 23 Dec 2017 02:52:07 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:39233 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbdLWHwF (ORCPT ); Sat, 23 Dec 2017 02:52:05 -0500 X-Google-Smtp-Source: ACJfBosi7I43bnbNMok4hyYb+qXibp3yFeWNfZ+4mbQvLy0X1WNOpjSBivgSNVxRRY3dI713udG54A== Subject: Re: [PATCH] arm: dts: mt7623: enable all four available UARTs on bananapi-r2 To: sean.wang@mediatek.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Matthias Brugger Message-ID: Date: Sat, 23 Dec 2017 08:52:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2016 Lines: 75 On 12/22/2017 07:06 AM, sean.wang@mediatek.com wrote: > From: Sean Wang > > On bpi-r2 board, totally there're four uarts which we usually called > uart[0-3] helpful to extend slow I/O devices. Among those ones, uart2 has > dedicated pin slot which is used to conolse log. uart[0-1] appear at the > 40-pins connector and uart3 has no pinout, but just has test points (TP47 > for TX and TP48 for RX, respectively) nearby uart2. Also, some missing > pinctrl is being complemented for those devices. > > Signed-off-by: Sean Wang > --- > arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > index 7bf5aa2..64bf5db 100644 > --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts > @@ -409,6 +409,20 @@ > ; > }; > }; > + > + uart2_pins_a: uart@2 { > + pins_dat { > + pinmux = , > + ; > + }; > + }; > + > + uart3_pins_a: uart@3 { > + pins_dat { > + pinmux = , > + ; > + }; > + }; > }; > > &pwm { > @@ -454,16 +468,24 @@ > &uart0 { > pinctrl-names = "default"; > pinctrl-0 = <&uart0_pins_a>; > - status = "disabled"; > + status = "okay"; > }; > > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&uart1_pins_a>; > - status = "disabled"; > + status = "okay"; > }; > > &uart2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart2_pins_a>; > + status = "okay"; > +}; > + > +&uart3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&uart3_pins_a>; > status = "okay"; > }; > Why do we want to enable uart3 when there are only test points? It is not very useful, or do I oversee something? Regards, Matthias