Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751905AbdLWKDn (ORCPT ); Sat, 23 Dec 2017 05:03:43 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:37731 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdLWKDk (ORCPT ); Sat, 23 Dec 2017 05:03:40 -0500 Subject: Re: [PATCH 06/11] ARM: davinci: constify gpio_led To: Arvind Yadav , , , , , , , , , , , , , , , , , , , , , , , , CC: References: From: Sekhar Nori Message-ID: <28bdbf7d-9784-dfee-7cdc-7ceb2fd02b99@ti.com> Date: Sat, 23 Dec 2017 15:31:52 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 789 Lines: 20 On Wednesday 20 December 2017 02:17 PM, Arvind Yadav wrote: > gpio_led are not supposed to change at runtime. > struct gpio_led_platform_data working with const gpio_led > provided by . So mark the non-const structs > as const. > > Signed-off-by: Arvind Yadav This causes a new section mismatch warning WARNING: vmlinux.o(.data+0x16d7c): Section mismatch in reference from the variable ntosd2_leds_data to the (unknown reference) .init.rodata:(unknown) The variable ntosd2_leds_data references the (unknown reference) __initconst (unknown) If the reference is valid then annotate the variable with __init* or __refdata (see linux/init.h) or name the variable: *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console Thanks, Sekhar