Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756947AbdLWOJj (ORCPT ); Sat, 23 Dec 2017 09:09:39 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:42312 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752272AbdLWOJd (ORCPT ); Sat, 23 Dec 2017 09:09:33 -0500 X-Google-Smtp-Source: ACJfBovmw2DMuuxEpwbPHEfpo7Ovr57S4tCMkeTHFUqKBZMD6EVXnhaNorlSUqr+1r+Nyll5/wBmlpPblKqTcVz+If8= MIME-Version: 1.0 In-Reply-To: <07ce3ca4-b1db-331d-9218-83a2e7cc2017@maciej.szmigiero.name> References: <07ce3ca4-b1db-331d-9218-83a2e7cc2017@maciej.szmigiero.name> From: Philippe Ombredanne Date: Sat, 23 Dec 2017 15:08:51 +0100 Message-ID: Subject: Re: [PATCH v5 3/6] cx25840: add pin to pad mapping and output format configuration To: "Maciej S. Szmigiero" Cc: Michael Krufky , Mauro Carvalho Chehab , Andy Walls , linux-kernel , Linux Media Mailing List , Hans Verkuil Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1703 Lines: 39 On Sat, Dec 23, 2017 at 12:18 AM, Maciej S. Szmigiero wrote: > This commit adds pin to pad mapping and output format configuration support > in CX2584x-series chips to cx25840 driver. > > This functionality is then used to allow disabling ivtv-specific hacks > (called a "generic mode"), so cx25840 driver can be used for other devices > not needing them without risking compatibility problems. > > Signed-off-by: Maciej S. Szmigiero > --- > drivers/media/i2c/cx25840/cx25840-core.c | 396 ++++++++++++++++++++++++++++++- > drivers/media/i2c/cx25840/cx25840-core.h | 13 + > drivers/media/i2c/cx25840/cx25840-vbi.c | 3 + > include/media/drv-intf/cx25840.h | 74 +++++- > 4 files changed, 484 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/cx25840/cx25840-core.c b/drivers/media/i2c/cx25840/cx25840-core.c > index 2189980a0f29..e2fd33a64550 100644 > --- a/drivers/media/i2c/cx25840/cx25840-core.c > +++ b/drivers/media/i2c/cx25840/cx25840-core.c > @@ -21,6 +21,9 @@ > * CX23888 DIF support for the HVR1850 > * Copyright (C) 2011 Steven Toth > * > + * CX2584x pin to pad mapping and output format configuration support are > + * Copyright (C) 2011 Maciej S. Szmigiero > + * > * This program is free software; you can redistribute it and/or > * modify it under the terms of the GNU General Public License > * as published by the Free Software Foundation; either version 2 Since you are touching the copyright here, I wonder if you could reach out to other copyright holders and switch to using an SPDX tag instead? -- Cordially Philippe Ombredanne