Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757209AbdLXEA4 (ORCPT ); Sat, 23 Dec 2017 23:00:56 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:39133 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbdLXEAv (ORCPT ); Sat, 23 Dec 2017 23:00:51 -0500 X-Google-Smtp-Source: ACJfBovV5Lzhp+9/eR3HLQQhMQjqvBwmF44PaQZ0IezUdPrlaie8B8vYqV0TXn2b8n1OOoSj8ybIxQ== From: Jia-Ju Bai To: kvalo@codeaurora.org, colin.king@canonical.com, johannes.berg@intel.com, tiwai@suse.de, kstewart@linuxfoundation.org, gregkh@linuxfoundation.org, andrew.zaborowski@intel.com Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post Date: Sun, 24 Dec 2017 12:03:43 +0800 Message-Id: <1514088223-7411-1-git-send-email-baijiaju1990@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 884 Lines: 24 b43_radio_2057_init_post is not called in an interrupt handler nor holding a spinlock. The function mdelay in it can be replaced with msleep, to reduce busy wait. Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/broadcom/b43/phy_n.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c index a5557d7..5bc838e 100644 --- a/drivers/net/wireless/broadcom/b43/phy_n.c +++ b/drivers/net/wireless/broadcom/b43/phy_n.c @@ -1031,7 +1031,7 @@ static void b43_radio_2057_init_post(struct b43_wldev *dev) b43_radio_set(dev, R2057_RFPLL_MISC_CAL_RESETN, 0x78); b43_radio_set(dev, R2057_XTAL_CONFIG2, 0x80); - mdelay(2); + msleep(2); b43_radio_mask(dev, R2057_RFPLL_MISC_CAL_RESETN, ~0x78); b43_radio_mask(dev, R2057_XTAL_CONFIG2, ~0x80); -- 1.7.9.5