Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751898AbdLYDJM (ORCPT ); Sun, 24 Dec 2017 22:09:12 -0500 Received: from mail-ot0-f193.google.com ([74.125.82.193]:41060 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbdLYDJI (ORCPT ); Sun, 24 Dec 2017 22:09:08 -0500 X-Google-Smtp-Source: ACJfBoveUSp/jsGK11ac8cSFo9iTe0iZf4GeUuY6sB5ja/k5MEl4sd7YNC9eHq4lO9iX5ulr7EM09qgVMr3XTQKp7wk= MIME-Version: 1.0 In-Reply-To: <1513860222-40944-5-git-send-email-pbonzini@redhat.com> References: <1513860222-40944-1-git-send-email-pbonzini@redhat.com> <1513860222-40944-5-git-send-email-pbonzini@redhat.com> From: Wanpeng Li Date: Mon, 25 Dec 2017 11:09:07 +0800 Message-ID: Subject: Re: [PATCH 4/4] KVM: nVMX: initialize more non-shadowed fields in prepare_vmcs02_full To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 474 Lines: 11 2017-12-21 20:43 GMT+08:00 Paolo Bonzini : > These fields are also simple copies of the data in the vmcs12 struct. > For some of them, prepare_vmcs02 was skipping the copy when the field > was unused. In prepare_vmcs02_full, we copy them always as long as the > field exists on the host, because the corresponding execution control > might be one of the shadowed fields. Why we don't need to copy them always before the patchset? Regards, Wanpeng Li