Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751706AbdLYISh (ORCPT ); Mon, 25 Dec 2017 03:18:37 -0500 Received: from mail-sn1nam02on0077.outbound.protection.outlook.com ([104.47.36.77]:20864 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750806AbdLYISf (ORCPT ); Mon, 25 Dec 2017 03:18:35 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH v2 00/12] drm: add check if io_mem_pfn is NULL and cleanup To: Tan Xiaojun , seanpaul@chromium.org, airlied@linux.ie, michel.daenzer@amd.com, alexander.deucher@amd.com, nicolai.haehnle@amd.com, thomas.lendacky@amd.com, yamada.masahiro@socionext.com, msrb@suse.com, Felix.Kuehling@amd.com, dave.jiang@intel.com, gregkh@linuxfoundation.org, michael.thayer@oracle.com, hdegoede@redhat.com Cc: daniel.vetter@intel.com, jani.nikula@linux.intel.com, wangzhou1@hisilicon.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1514173414-28325-1-git-send-email-tanxiaojun@huawei.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <97ceaf9e-3d04-89a6-062b-6c9170a501a9@amd.com> Date: Mon, 25 Dec 2017 09:18:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1514173414-28325-1-git-send-email-tanxiaojun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [2a02:908:1251:7981:c87c:c433:7483:9b82] X-ClientProxiedBy: AM6PR0102CA0011.eurprd01.prod.exchangelabs.com (52.133.26.24) To BN6PR12MB1298.namprd12.prod.outlook.com (10.168.227.148) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dbd4465-8f9d-4935-416b-08d54b701522 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603307)(7153060);SRVR:BN6PR12MB1298; X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;3:+jSFv5s2eI3CC+39n6iQrTr0eUOu6D1BQuNxLCyBO0vPlUngvjPRzfTRx8NTv+cNbJ9qkFdvGg3XivBGyUN9FVJaUTz+OlV0kovLrSaf2oYi3uAac9rVoMpqAkYH4Qzmvmdc6gu+wvdTSkxy+e3iV9uV7/ztiqYPUVaprgQtVmSE7PWZZWiswS0s6b6ZpyOs1BEYppX0zRpuHDY0/y7oOxjPZAgoKXl9bXUUDKLYo1VKOVYgW0N1oHf6q12BXEWh;25:CbKbikdaK1PLh0MBbIRzcR/4Hb7XIaiK9PEDJiF5qGvuhxHuiGjgAigCIgTTp55USWc9oTY9+NosOLrxpfxMZOFdc3vK61ZXMchj75J5hesY/riB5RzZSqqNJolohds6Nh+vxGq1nbMT3X3KHi0+/T+qe3q20wU1uUpayqO3YqJirrfAW7ZfdSPkJYGXCLKeniv/nZSK7Bhh6+Z20tIng+U4x7la3Tb6BW4qhlAasDib47AMx7d+tNH0codzUpMpc6KVvXia7SaAOMsaTJ62B4gzTGW5uwNZuSW0YEpILb6P7DXYrYalLJjkcEj40LZJ2ydig62Wr3p6rcpXuRoVeA==;31:9NBLNEEnoa8Dbkz8Bjcf8KGT64F2HpjCIqP1puW9s9pKW1rhEcw+aXoqJDlGa9UKvPMoxhLnoTlRWNAN61ELIN9s4Xu1i9YGzpIKC8kQLO2BNkvT9hkfyLXV3YNKGqOq9h5ieAULd4XT2tUeNWTt5VfaOgPyR6B2r8bCtAf7Xm9SVfxEFvzAhIONRS1ofA0vqFg/a/LjDZ0sxLdhFiVYDlLij9iAB0UaAuXs0E3537g= X-MS-TrafficTypeDiagnostic: BN6PR12MB1298: X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:AXqObkhizS0Rc38dIgantspuzHKUukOb3djp4SdjRXdwLGdFkKlk+m33BdSYdEipMWutW6HQF5cgTEz6V7rUvZrCODInkyXyJiAQe8YH0ZPzEiy6cG0KZDia2vlEY4g9GhBrxw8j70FB0XxO+MhJ/ZnHup/x1yrBePHUWDzZC/aeKkKSrgTPG17yv8NB6QXrZ7z41CFpKbxVYMHvnneCnat+vzXFZkkHlnmQAx7eAuU4eCYaOL7+KJTW81JlD7JuMxUNzDrMrR6KDc/x47RnqJc3JdIfJu5a0ZKvL4N6pRgTab+JdaRQNg7SVUwSAUvcYt8oCW1jK3DwIytkCW1IZ0zlCbcOKoNn65qOvRW0veVaWxClZ+dkP50Jl47FVtOIM8kBlmdnKPvV7tzczdXKVkHcj9MLdFW9iT4ljG3MUDgiYMFzPhVdxA6h+YC7iyVYq1PGxy9bzET3g3z+P1TYjG/DR1DX+0UQdstnQiCNGaaY32hHl3asjjJSSc3zsliY;4:9+3TPsk2ejo0FhngOJ5Qf35UY7tgy1WHtCawrXLDwkqJk17rEY+B1PiIOizeFAMqeNN+PLXkJg3kJ2AZOfepcdZNefzxf7ZreoX4HM2/rT2Sz1+2CipKyL5gBR0XWVMtT4KDv2thCsdIjqzinlumzt1HhralY3VM3NJG6P+xKQGWzDmbdUVa0M10wIPP8DvmYe+n6PKlaEAnKtgryjKMzVHyNg1fcpRuZa+il/7uABoHWorxHLGtRDMqeXs8go/uklr1hXS3iVFQQaEZCE4c2VMTMsM8FgZbPuduFe2ORbFYHtKpk5esGL0xOymDCyU/qfjGC/T042P6hbFIwRSDVw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(217544274631240); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501075)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041268)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(6072148)(201708071742011);SRVR:BN6PR12MB1298;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:BN6PR12MB1298; X-Forefront-PRVS: 0532BF6DC2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(396003)(39380400002)(376002)(366004)(39860400002)(346002)(54534003)(51914003)(199004)(189003)(966005)(72206003)(386003)(6116002)(23676004)(52146003)(2486003)(65826007)(52116002)(52396003)(305945005)(50466002)(36756003)(53936002)(5660300001)(106356001)(105586002)(97736004)(31686004)(478600001)(58126008)(316002)(7736002)(68736007)(86362001)(76176011)(25786009)(8676002)(59450400001)(4326008)(7416002)(81156014)(31696002)(6246003)(2870700001)(81166006)(6306002)(67846002)(1706002)(6486002)(64126003)(2950100002)(229853002)(83506002)(65956001)(65806001)(6666003)(47776003)(2906002)(8936002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1298;H:[IPv6:2a02:908:1251:7981:c87c:c433:7483:9b82];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjZQUjEyTUIxMjk4OzIzOnhIMENhRmRqbEtTZW1RK0M2ZDUrL21mNmd3?= =?utf-8?B?MGFQWTJMMVl3Unh0cFN6ejhud2ZnZk51NFltOUxyR3NQd2xpZm1JeG9HdWY3?= =?utf-8?B?RHM0S3djb21WZkpDVXcvQ2MzK2FQS3lKS0pUWlRuREJXczNTRjVlZUd3SzM1?= =?utf-8?B?TnhBSExmalh1NFFYeEhscUNuWVRocnFBT1RKMnVKbC81S3dBVWUrb3FxRSt3?= =?utf-8?B?bDVwaDVlZnRsVGZKczJBd1ZjbW8xay9vZGhkUnFIYmg1V01obEtncTQ4V25P?= =?utf-8?B?MWI2MzNUNmhUb0I2dW96eEtRNWJsWjAzMjNtTU5ua1d5QnNKNEorSnBPUE14?= =?utf-8?B?dTVHVjVyMUNYRUdkUHFhZmdKVTdQU2tDenpReUF5K2tWOTF3ckRZNkZlU3Bk?= =?utf-8?B?Y051K1BJOEM2WXZFY0RqTXh2WHA2T2FtNVNGVENGVkVud2RTZlRFTW8yVnB2?= =?utf-8?B?TTh6eTZiQVNqOHlGUFFyVnZueGcya1pIemNIUG5McnlGVmduS0o5ZFU4YkpE?= =?utf-8?B?TXNpbXJrNFM4NFJDbkJMMG0rWmpaUVplQUhkc2NVSVZqZ1BmVHhzdWs2WnhV?= =?utf-8?B?c3RjNURHT2pVanIzSTY5d0dLMW1obFozQzY1dmZxakpVL3k0anRYRU5HdmZT?= =?utf-8?B?M0lmci9nQ3d1alMzTmVXSkpOQm1Ka1pqUisxV1ppWTBTQ2JEOG9rZE5SSlll?= =?utf-8?B?d0Exck02ZmRRSENnbFpwcmtSMVRFZGZsQThqUHdIam1KM25wYnVwYW9iZFNK?= =?utf-8?B?eVBPVFhRYzlEQTBQOURmYzc0YkxDcW5MNmViQzVtS1RiRER1WDZvSEZoOVFx?= =?utf-8?B?VGFRWm00OHNZS1dEOFBabkpaeENxTUJWWnh6WFRpZ0RDazBrL29vMjhPWlRB?= =?utf-8?B?cGp6eFdYNFN5Mm9BZkxhYkc4dTNyRE1FcGJMSFRTcUhkVGgvdDg0aTY4SHN6?= =?utf-8?B?VjVWVXRFUjBYZzFTWE1seEFhVXNxR0c3cHRLa0JNNlZlOWhDa3FwS291emZl?= =?utf-8?B?MWVxVzNvV1Mvc0JHN2Q0bmQzMlFIVHIycmlWbDVvUnpZWFR3dkpOb0NGQnlR?= =?utf-8?B?YW54SFB0WEF1VGl3aGNSeFQzM2NQNWRVZTdCNE5ob2NMUVNIQ1laNFRGZ1pn?= =?utf-8?B?OGY2S25COGZuQWRrVEF1YTVTc0FQTGQvMG5DWnl1LzM5Vk1QeWZRdkJqaTVK?= =?utf-8?B?NWp4TklMeTE0MWM3bzJTS2lBQUZDVThvSU1CR0ZnMWFIdi9oY2doOVJMejRG?= =?utf-8?B?RHA1NDdjNG5GWnJodUtaTjZFQ3ZWemszV2F1THRjZE5MbUpCUlpqYnRpanox?= =?utf-8?B?eFlKVWtBSEdlWnk1T0NINE5aQkFxNHRzTUh0QWlXekJacHduWHFaQzJlYkpu?= =?utf-8?B?MXNYSHVtQzNvV0lZc3N3K1ovZXBKV0NIQUJwdi9MeXlDdmhmb25pT2VIclhv?= =?utf-8?B?eG9MVjFPaXIwcGFEYytlSkFOODMrRzdVVGVnMGE4dUpYai9kQ3c5YjQzVm5u?= =?utf-8?B?YkVQM1NGVWxJTmlPblh6d01KNTg2Mng4aWZZcWxMQmUvelFxYldFZ3c0cjVE?= =?utf-8?B?SGJ1ZGFRMnVRc082TUxwVnFwRml0UXZDTkxOMUZNWWRGMm1EVDJJcWtEbjFP?= =?utf-8?B?Z0Uvbk1pZVJjQTV5TU5pWUpCTmREZUdwenNjaER0SXp0cHpwVDFNYm5xMDlG?= =?utf-8?B?N2ExYTIzSlJ4L1M1SVdBcTlIaXoxSDIvZW43M05uN0pnL21HMU9JUHZZdjA0?= =?utf-8?B?NW90Qzl1RE9kSE11OExSVDJjdmxOR3hUNllSR01YNHdwU0JTNFVPaThUN2ZV?= =?utf-8?B?VUpLSkFWWjA2SWxGSGJSbzJDS2pOcThURW5lTkdDM0lucjdOVmE2Q05TWXR4?= =?utf-8?B?Vkc1VndGdThvL3FUdklxNHdSLzgrYStSQ2RNNmpBTWNJeDZmWThnV3FkNTYy?= =?utf-8?B?LzdnOTVrcFZnPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;6:mIJ3MmYM2HrAuvSNXx0U/KT7JwB38lndT7jsCKbcy6JdgDtzgIDdOjzJkOi7ZrwiyxLQ4kBfK7sgoDTKjf8qAtPJnw/BQ0k2xQfSMc4y6ku5uRVHHzFY/SnW4lACT3jvQX5Evur1VCeiSgQ+cjK6tf4WPmg1g/KmPryM1dsJxcaolbnUkQTroMVXLbXcR0CKvFpwbZrRGhVCBK2nhBKqF8Rt5El+8EJgrO7CPOJ+PJPzfqgVfvSSuSnavvMd9YoA3rXbPBf+cYlXNbP6OGD/TVfxsFTXrWGW38/FRJ2x/Ju9wHE7cI0f5rv80xopPCE0QHxqwmSA9gJap7SrKA9wg4f1QUUmuPrixIaGp/Lm7gw=;5:KfwqXxYz584hacjullJMxyuog0UVsp0hmRZk/4+akphYSab+FP6xp8pwfpRq4LQAC7QHDv4tLMjPQvOlIaJUV2waZnJCkCtY6HYaNNAVKpmj/BJUwVoQXn4N/n/x3rBZzUvfM4RjjxSJdDzqHUw+m4RKlUdDM1qABKBCYjCoj9o=;24:wa3YHXjBvwjah8Gl50lWx+977wnG82RDMeeOUCfataNDo9pR+2SG49gsgWvTGSQi3GxRDW/7ubl8DhtR20pPhGgEuDPXVJswP4D12sFSjf0=;7:G83GsluxelrFdVjxOHafVk8ju19t54Ar798sng4BGVo2qijzqDXR4i70etF557Gyi31wQW7zyK5rEdjstzazgT8o9ShFSc7FwAs1+Yk/BVWRg3+YPspeMlEt+amBT48xOmx/IovM1EvsL7HqEVGIiMUbx5CiKCtIM/TAgVb0avPSdjrW7ozYrIhuZ/npR2nypBnFf31TVNRpPNfcox8JbEShAw4+pgWwLHwp/YrVrlWvNedQ7WD8N3Rsj5SWCFpY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR12MB1298;20:UIbnd31mu7+uY5NAcaOgugDsU0jkemfJXUwqKCCxctLou8mEvtJ3HkSVNZLzcrslt40mzei+vHVA9hRlRUkQdj5HdDxD2jIib3xgJxNRmAyMgnLW4EUSUD+9lTzooK0fAPGbT+L6miW8bdYnpEeIv3yjs/snQHBZDSbLrsfnIb971HKcf6iRH0ItIXE01TW1nW5Y2QpaP3uMApDMTFIaGxsWZPC0x796/m7uUGPzKGVeGxL/04o/uNvcHLS05V2G X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2017 08:18:27.0150 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5dbd4465-8f9d-4935-416b-08d54b701522 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1298 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2164 Lines: 53 Series is Reviewed-by: Christian König . I'm going to pick that up for 4.16. Thanks for the cleanup, Christian. Am 25.12.2017 um 04:43 schrieb Tan Xiaojun: > I found an OOPS when I used the mainline kernel for graphical tests in Hisilicon > D05, I do not know how to solve this problem until I saw your discussion on this > issue a month ago: > > https://lists.freedesktop.org/archives/dri-devel/2017-November/159046.html > > And my problem can be solved perfectly by your solution. > > This is important for me, I want to solve this problem as soon as possible. So > I follow the result of your discussion, make and send these patches below. > > If anything is not good, please point it out, thanks. > > Change logs of v2: > * add new function to instead of ttm_bo_default_io_mem_pfn() and > do some cleanup. > > Tan Xiaojun (12): > drm/ttm: add ttm_bo_io_mem_pfn to check io_mem_pfn > drm/ast: remove the default io_mem_pfn set > drm/bochs: remove the default io_mem_pfn set > drm/cirrus: remove the default io_mem_pfn set > drm/mgag200: remove the default io_mem_pfn set > drm/nouveau: remove the default io_mem_pfn set > drm/qxl: remove the default io_mem_pfn set > drm/radeon: remove the default io_mem_pfn set > drm/virtio: remove the default io_mem_pfn set > drm/vmwgfx: remove the default io_mem_pfn set > staging: remove the default io_mem_pfn set > drm/ttm: remove ttm_bo_default_io_mem_pfn > > drivers/gpu/drm/ast/ast_ttm.c | 1 - > drivers/gpu/drm/bochs/bochs_mm.c | 1 - > drivers/gpu/drm/cirrus/cirrus_ttm.c | 1 - > drivers/gpu/drm/mgag200/mgag200_ttm.c | 1 - > drivers/gpu/drm/nouveau/nouveau_bo.c | 1 - > drivers/gpu/drm/qxl/qxl_ttm.c | 1 - > drivers/gpu/drm/radeon/radeon_ttm.c | 1 - > drivers/gpu/drm/ttm/ttm_bo_vm.c | 22 +++++++++++++--------- > drivers/gpu/drm/virtio/virtgpu_ttm.c | 1 - > drivers/gpu/drm/vmwgfx/vmwgfx_buffer.c | 1 - > drivers/staging/vboxvideo/vbox_ttm.c | 1 - > include/drm/ttm/ttm_bo_api.h | 11 ----------- > 12 files changed, 13 insertions(+), 30 deletions(-) >