Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbdLYNEj (ORCPT ); Mon, 25 Dec 2017 08:04:39 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:36496 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751786AbdLYNEg (ORCPT ); Mon, 25 Dec 2017 08:04:36 -0500 X-Google-Smtp-Source: ACJfBou7Kp24elBcf2ZSfHkDBqCnhMP8DI3GZvV/YrieTN0IdAKCV1L7k/kmRNr/z/HxWEFe0VqwCQ== Subject: Re: [PATCH 11/11] ARM: pxa: constify gpio_led To: kbuild test robot References: <6cd4fa3a594e5aae6e6a4d9cf8f7ba96e18c6c61.1513756005.git.arvind.yadav.cs@gmail.com> <201712250154.QftmBzUp%fengguang.wu@intel.com> Cc: kbuild-all@01.org, nsekhar@ti.com, khilman@kernel.org, linux@armlinux.org.uk, kaloz@openwrt.org, khalasa@piap.pl, aaro.koskinen@iki.fi, tony@atomide.com, jason@lakedaemon.net, andrew@lunn.ch, sebastian.hesselbarth@gmail.com, gregory.clement@free-electrons.com, daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, marek.vasut@gmail.com, slapin@ossfans.org, jic23@cam.ac.uk, kgene@kernel.org, krzk@kernel.org, ralf@linux-mips.org, ysato@users.sourceforge.jp, dalias@libc.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org From: arvindY Message-ID: <5A40F758.6060101@gmail.com> Date: Mon, 25 Dec 2017 18:34:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <201712250154.QftmBzUp%fengguang.wu@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5026 Lines: 103 Hi, Sorry for trouble, I will send updated patch. On Sunday 24 December 2017 11:24 PM, kbuild test robot wrote: > Hi Arvind, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on arm-soc/for-next] > [also build test ERROR on v4.15-rc5 next-20171222] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Arvind-Yadav/constify-gpio_led/20171223-142117 > base: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git for-next > config: arm-pxa_defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > make.cross ARCH=arm > > All error/warnings (new ones prefixed by >>): > >>> arch/arm/mach-pxa/balloon3.c:390:8: error: expected '{' before 'const' > struct const gpio_led balloon3_gpio_leds[] __initconst = { > ^~~~~ >>> arch/arm/mach-pxa/balloon3.c:405:11: error: 'balloon3_gpio_leds' undeclared here (not in a function); did you mean 'balloon3_gpio_led_info'? > .leds = balloon3_gpio_leds, > ^~~~~~~~~~~~~~~~~~ > balloon3_gpio_led_info > In file included from include/linux/kernel.h:15:0, > from include/linux/list.h:9, > from include/linux/kobject.h:20, > from include/linux/device.h:17, > from include/linux/platform_device.h:14, > from arch/arm/mach-pxa/balloon3.c:18: >>> include/linux/build_bug.h:30:45: error: bit-field '' width not an integer constant > #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); })) > ^ > include/linux/compiler-gcc.h:65:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO' > #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0])) > ^~~~~~~~~~~~~~~~~ > include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array' > #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) > ^~~~~~~~~~~~~~~ >>> arch/arm/mach-pxa/balloon3.c:406:14: note: in expansion of macro 'ARRAY_SIZE' > .num_leds = ARRAY_SIZE(balloon3_gpio_leds), > ^~~~~~~~~~ > -- >>> arch/arm/mach-pxa/palmld.c:249:8: error: expected '{' before 'const' > struct const gpio_led gpio_leds[] __initconst = { > ^~~~~ >>> arch/arm/mach-pxa/palmld.c:262:11: error: 'gpio_leds' undeclared here (not in a function); did you mean 'gpio_led'? > .leds = gpio_leds, > ^~~~~~~~~ > gpio_led > In file included from include/linux/kernel.h:15:0, > from include/linux/list.h:9, > from include/linux/kobject.h:20, > from include/linux/device.h:17, > from include/linux/platform_device.h:14, > from arch/arm/mach-pxa/palmld.c:17: >>> include/linux/build_bug.h:30:45: error: bit-field '' width not an integer constant > #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:(-!!(e)); })) > ^ > include/linux/compiler-gcc.h:65:28: note: in expansion of macro 'BUILD_BUG_ON_ZERO' > #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0])) > ^~~~~~~~~~~~~~~~~ > include/linux/kernel.h:71:59: note: in expansion of macro '__must_be_array' > #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr)) > ^~~~~~~~~~~~~~~ >>> arch/arm/mach-pxa/palmld.c:263:14: note: in expansion of macro 'ARRAY_SIZE' > .num_leds = ARRAY_SIZE(gpio_leds), > ^~~~~~~~~~ > > vim +390 arch/arm/mach-pxa/balloon3.c > > 389 > > 390 struct const gpio_led balloon3_gpio_leds[] __initconst = { > 391 { > 392 .name = "balloon3:green:idle", > 393 .default_trigger = "heartbeat", > 394 .gpio = BALLOON3_GPIO_LED_IDLE, > 395 .active_low = 1, > 396 }, { > 397 .name = "balloon3:green:nand", > 398 .default_trigger = "nand-disk", > 399 .gpio = BALLOON3_GPIO_LED_NAND, > 400 .active_low = 1, > 401 }, > 402 }; > 403 > 404 static struct gpio_led_platform_data balloon3_gpio_led_info = { > > 405 .leds = balloon3_gpio_leds, > > 406 .num_leds = ARRAY_SIZE(balloon3_gpio_leds), > 407 }; > 408 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation