Message-ID: <87k1xah0e5.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Ryan Lee <RyanS.Lee@maximintegrated.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "perex@perex.cz" <perex@perex.cz>, "tiwai@suse.com" <tiwai@suse.com>,
        "arnd@arndb.de" <arnd@arndb.de>, "afd@ti.com" <afd@ti.com>,
        "robert.jarzmik@free.fr" <robert.jarzmik@free.fr>,
        "supercraig0719@gmail.com" <supercraig0719@gmail.com>,
        "jbrunet@baylibre.com" <jbrunet@baylibre.com>,
        "dannenberg@ti.com" <dannenberg@ti.com>,
        "romain.perier@collabora.com" <romain.perier@collabora.com>,
        "bryce.ferguson@rockwellcollins.com" 
        <bryce.ferguson@rockwellcollins.com>,
        "m-stecklein@ti.com" <m-stecklein@ti.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ryan.lee.maxim@gmail.com" <ryan.lee.maxim@gmail.com>
Subject: Re: [PATCH] ASoC: max98373: Added Amplifier Driver
In-Reply-To: <BY2PR11MB0837C049BCA0C1B5103EA3FBE7010@BY2PR11MB0837.namprd11.prod.outlook.com>
References: <1513907030-18441-1-git-send-email-ryans.lee@maximintegrated.com>
        <87a7ybo6em.wl%kuninori.morimoto.gx@renesas.com>
        <BY2PR11MB0837C049BCA0C1B5103EA3FBE7010@BY2PR11MB0837.namprd11.prod.outlook.com>
User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Date: Mon, 25 Dec 2017 23:17:29 +0000
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Dec 2017 23:17:29.5045 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5aa8c8de-1d70-444d-764b-08d54bedac6e
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR0601MB1886
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 931
Lines: 29


Hi Ryan

> >About this max98373->codec.
> >This user is only max98373_set_clock(), and it is called from
> >max98373_dai_hw_params().
> >You are getting *codec from dai->codec in this function, and max98373 is
> >came from it.
> >This means, we can remove max98373->codec ?
> 
> Thanks for your feedback.
> I will remove max98373->codec and change related things.

Thanks

> I'm sorry but I don't fully understand the benefit of this.
> Keeping regmap information in private driver data is very common and I can see many ASoC drivers are using it.
> I was able to see only a few driver use ' snd_soc_component_read'.
> I would like to keep regmap_read/write if it is still acceptable.

I checked other drivers.
Having private regmap seems a little bit duplicate for me,
because we can get it from component or dev.
But sometimes, in some drivers, it seems can be difficult.
Sorry for my noise.

Best regards
---
Kuninori Morimoto